-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: redact secret strings when logging arguments (#57593) #57606
Open
ti-chi-bot
wants to merge
2
commits into
pingcap:release-6.1
Choose a base branch
from
ti-chi-bot:cherry-pick-57593-to-release-6.1
base: release-6.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
br: redact secret strings when logging arguments (#57593) #57606
ti-chi-bot
wants to merge
2
commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-57593-to-release-6.1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kennytm <kennytm@gmail.com>
ti-chi-bot
added
component/br
This issue is related to BR of TiDB.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/bugfix
This PR fixes a bug.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
labels
Nov 21, 2024
13 tasks
kennytm
reviewed
Nov 21, 2024
/retest |
kennytm
approved these changes
Nov 22, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kennytm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
approved
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
component/br
This issue is related to BR of TiDB.
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/bugfix
This PR fixes a bug.
type/cherry-pick-for-release-6.1
This PR is cherry-picked to release-6.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57593
What problem does this PR solve?
Issue Number: close #57585
Problem Summary: Some values from the command line are not properly redacted.
What changed and how does it work?
In additional to the existing handling for
--storage
, we also apply redaction to the following parameters:--full-backup-storage
--crypter.key
--log.crypter.key
--azblob.encryption-key
--master-key
(the current implementation of this may be too conservative)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.