-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: refactor test to use wait checkpoint method #57612
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57612 +/- ##
================================================
+ Coverage 73.2689% 74.3187% +1.0498%
================================================
Files 1650 1691 +41
Lines 455646 489758 +34112
================================================
+ Hits 333847 363982 +30135
- Misses 101279 103622 +2343
- Partials 20520 22154 +1634
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
@Tristan1900: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #57609
Problem Summary:
What changed and how does it work?
Extract the wait for checkpoint to advance logic in integration test to a method
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.