-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Fix predicate simplification panic caused by zero-argument expressions like rand() (#56947) #57618
base: release-8.5
Are you sure you want to change the base?
planner: Fix predicate simplification panic caused by zero-argument expressions like rand() (#56947) #57618
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57618 +/- ##
================================================
Coverage ? 55.1988%
================================================
Files ? 1768
Lines ? 626171
Branches ? 0
================================================
Hits ? 345639
Misses ? 255246
Partials ? 25286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #56947
What problem does this PR solve?
Issue Number: close #56270
Problem Summary:
What changed and how does it work?
When checking predicate type in predicate simplification, it will use arg[0] to judge if the arg is *expression.Column, however, "rand()" has 0 argument, which will lead a panic.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.