Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpling, lightning: add partition table test cases #57619

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 22, 2024

What problem does this PR solve?

Issue Number: close #57623

Problem Summary: Add some test cases for dumpling and lightning with partition table and global index.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 Defined2014 added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 22, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2024
Copy link

tiprow bot commented Nov 22, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7557%. Comparing base (fe1b9ed) to head (557a35d).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57619        +/-   ##
================================================
+ Coverage   72.8112%   73.7557%   +0.9444%     
================================================
  Files          1676       1706        +30     
  Lines        463677     472838      +9161     
================================================
+ Hits         337609     348745     +11136     
+ Misses       105228     102635      -2593     
- Partials      20840      21458       +618     
Flag Coverage Δ
integration 46.6496% <ø> (?)
unit 72.3808% <ø> (+0.1688%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4468% <ø> (-0.0121%) ⬇️
---- 🚨 Try these New Features:

@Defined2014 Defined2014 changed the title dumpling: add partition table test cases dumpling, lightning: add partition table test cases Nov 22, 2024
@Defined2014 Defined2014 removed the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 22, 2024
@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2024
Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 22, 2024
Copy link

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-22 06:34:23.46166637 +0000 UTC m=+186251.081320886: ☑️ agreed by D3Hunter.
  • 2024-11-22 07:39:15.716448058 +0000 UTC m=+190143.336102575: ☑️ agreed by lance6716.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 6e22b8c into pingcap:master Nov 22, 2024
30 checks passed
@Defined2014 Defined2014 deleted the add-test-cases branch November 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global index related test cases for lightning and dumpling
3 participants