Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix a wrong privilege check for CTE & UPDATE statement (#57430) #57624

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57430

What problem does this PR solve?

Issue Number: close #53490

Problem Summary:

What changed and how does it work?

See #53490 (comment), for statement like:

with t_f as (
         select id,pid,name,'AAA' fullname from test.tt1 )
         update test.tt1 inner join t_f
         set tt1.fullname=t_f.fullname
         where tt1.id=t_f.id;

The privilege check for CTE in the update statement should be avoided.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Therocially it consumes more CPU to remove the privilege check, but I believe the real world performance will not be impacted.

Documentation

  • NA

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a wrong privilege check when using the `UPDATE` statement with CTE

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@d2978bc). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57624   +/-   ##
================================================
  Coverage               ?   56.8867%           
================================================
  Files                  ?       1770           
  Lines                  ?     626575           
  Branches               ?          0           
================================================
  Hits                   ?     356438           
  Misses                 ?     246108           
  Partials               ?      24029           
Flag Coverage Δ
integration 36.9464% <83.3333%> (?)
unit 72.5737% <83.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.4601% <0.0000%> (?)
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 22, 2024
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 06:10:44.82626734 +0000 UTC m=+444032.445921857: ☑️ agreed by bb7133.
  • 2024-11-25 06:14:14.100781527 +0000 UTC m=+444241.720436043: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 0468b8e into pingcap:release-8.5 Nov 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants