-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix that vector index output empty result when pk is non-int type #57629
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57629 +/- ##
================================================
+ Coverage 72.8127% 73.4323% +0.6195%
================================================
Files 1676 1676
Lines 463751 464662 +911
================================================
+ Hits 337670 341212 +3542
+ Misses 105205 102631 -2574
+ Partials 20876 20819 -57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
if prop.VectorProp.VectorHelper != nil && path.Index != nil && path.Index.VectorInfo != nil { | ||
if path.Index == nil || path.Index.VectorInfo == nil { | ||
return false | ||
} | ||
if ds.TableInfo.Columns[path.Index.Columns[0].Offset].ID != prop.VectorProp.Column.ID { | ||
return false | ||
} | ||
|
||
if model.IndexableFnNameToDistanceMetric[prop.VectorProp.DistanceFnName.L] != path.Index.VectorInfo.DistanceMetric { | ||
return false | ||
} | ||
return true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to the highest priority.
Because when for the vector index path, the IsIntHandlePath
can also be true. We need to use a new way to check the real pk path.
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: close #57627
Problem Summary:
What changed and how does it work?
When pk is clustered and non-int, the full range should be
[MinNotNull, MaxValue]
. But it's[MinInt64, MaxInt64]
currently. So it will output an empty result.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.