Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): add flushLogs method to tests #16

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

BioPhoton
Copy link
Contributor

@BioPhoton BioPhoton commented Feb 15, 2024

πŸ”— Linked issue

#15

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds better testing experience.

Resolves #15

πŸ“ Checklist

  • I have read the contribution guide.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Julien-R44
Copy link
Member

Please lint/format the code

@BioPhoton
Copy link
Contributor Author

I was doing that but reverted the changes as it also changed other files that I did not touch.

So I thought there must be something wrong, either not integrated or format:check is not running in CI.

Anyway if this is how it works here why not. Will format!

@BioPhoton
Copy link
Contributor Author

done

@thetutlage thetutlage merged commit e033529 into poppinss:develop Feb 16, 2024
6 checks passed
@thetutlage
Copy link
Member

Looks good. Thanks πŸ‘

@thetutlage
Copy link
Member

@BioPhoton BioPhoton deleted the add-flush-method-to-logger branch February 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flush method to empty the logs array in logger
3 participants