Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parse-errors): ensure if block execution #1854

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

kmosti
Copy link
Contributor

@kmosti kmosti commented Apr 3, 2024

When error messages contains more than one object, ensure that they are all parsed.

@mariadeluna-tomtom
Copy link

Hi @kmosti, are you planning to get this merged anytime soon?

@dimitarOnGithub
Copy link

@adehad just wanted to bring this one to your attention as I think that this PR should fix both #1846 and #1872

@kmosti
Copy link
Contributor Author

kmosti commented Aug 30, 2024

Hi @kmosti, are you planning to get this merged anytime soon?

I made an issue, a PR and messaged the group here https://app.element.io/#/room/#pycontribs:matrix.org, not sure what more I can do to have someone review / merge this PR.

kmosti and others added 2 commits August 30, 2024 13:09
When error messages contains more than one object,
ensure that they are all parsed.
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you for the contribution, sorry for the delay in getting this in

@adehad adehad merged commit 196194a into pycontribs:main Aug 30, 2024
15 checks passed
Wojtini pushed a commit to Wojtini/jira that referenced this pull request Sep 2, 2024
When error messages contains more than one object,
ensure that they are all parsed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants