Collect more reliable trace_env #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And create more helpers for testing various more complicated success and failure modes. Fixes #1994
DavisVaughan
approved these changes
Nov 6, 2024
Comment on lines
+83
to
+84
| expect_no_failure <- function(expr) { | ||
| exp <- capture_failure(expr) |
There was a problem hiding this comment.
Maybe add a test? (i see you do have one for expect_no_success(), and existing ones for expect_snapshot_failure())
There was a problem hiding this comment.
Like expect_failure(expect_no_failure(expect_true(FALSE)))? 😆
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And create more helpers for testing various more complicated success and failure modes.
Fixes #1994
@DavisVaughan no need to go deep here on the actual implementation/fix, but I'd appreciate your eyes on the newly exported expectation test helpers.