Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare for 8.4.0 release (RMCCX-7310) #329

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: prepare for 8.4.0 release (RMCCX-7310) #329

merged 2 commits into from
Sep 17, 2024

Conversation

SoumenRautray
Copy link
Contributor

@SoumenRautray SoumenRautray commented Sep 16, 2024 •
edited
Loading

Description

Release for 8.4.0

Links

[RMCCX-7310]

Checklist

  • I have read the contributing guidelines
  • I have added to the changelog
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I ran fastlane ci without errors
  • All project file changes are replicated in SampleSPM/SampleSPM.xcodeproj project

@SoumenRautray SoumenRautray removed the request for review from anish-munirathinam September 16, 2024 05:40
@rakutentech-danger-bot
Copy link
Collaborator

rakutentech-danger-bot commented Sep 16, 2024 •
edited
Loading

4 Warnings
⚠️ This PR does not have any assignees yet
⚠️ Branch name "RMCCX-7310_release" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>
⚠️ Tests were not updated
⚠️ Commit message "chore: modify changelog (RMCCX-7310)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)

Current coverage for RInAppMessaging.framework is 90.11%

Files changed - -
Constants.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SoumenRautray SoumenRautray merged commit c50ce09 into rakutentech:master Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Esakkiraja-Pothikannan Esakkiraja-Pothikannan Esakkiraja-Pothikannan approved these changes

@maureenorea-clores maureenorea-clores Awaiting requested review from maureenorea-clores maureenorea-clores is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoumenRautray @rakutentech-danger-bot @Esakkiraja-Pothikannan