Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bookkeeping of ongoing calls for recursive calls to CallbackQueue::callAvailable() #2378

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Fix bookkeeping of ongoing calls for recursive calls to CallbackQueue::callAvailable() #2378

wants to merge 1 commit into from

Commits on Oct 8, 2024

  1. Fix bookkeeping of ongoing calls for recursive calls to CallbackQueue… 

    …::callAvailable()

When copying over pending calls to the thread-local callback queue held in tls->callbacks, the calling_
member was not updated correctly with the number of added callbacks if tls->callbacks was not empty before.
This may be the case if callAvailable() is called recursively, e.g. from within another callback.

The issue should only affect the empty() and isEmpty() member functions, which apparently are unused
within the CallbackQueue class or within roscpp itself, but may be used by external code.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
    @meyerj
    meyerj committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    50b3244 View commit details
    Browse the repository at this point in the history