Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roslaunch] Indicating <node> tag when it is actually a <test> tag is confusing. #989

Closed
wants to merge 1 commit into from

Commits on Feb 16, 2017

  1. [roslaunch] Indicating <node> tag when it is actually a <test> tag is…

    … confusing.
    
    For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):
    
     ```
     * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
        <group unless="$(arg expected_success)">
          <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
          <param name="hz" value="0.0"/>
        </group>
    ```
    
    This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.
    
    With this PR the message becomes a bit verbose but hope the readers get better idea.
    130s committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    58cf7ad View commit details
    Browse the repository at this point in the history