Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from tinyxml to tinyxml2 #186

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Upgrade from tinyxml to tinyxml2 #186

merged 13 commits into from
Dec 6, 2023

Commits on Nov 29, 2023

  1. upgrade from tinyxml to tinyxml2

    @felixf4xu @clalancette
    felixf4xu authored and clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9fd9cf6 View commit details
    Browse the repository at this point in the history

  2. More cleanups. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    06a18de View commit details
    Browse the repository at this point in the history

  3. Remove 'using tinyxml2' 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2f45917 View commit details
    Browse the repository at this point in the history

  4. Update github actions. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f2a2ce5 View commit details
    Browse the repository at this point in the history

  5. Add in FindTinyXML2 for systems that don't have it. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2383a0a View commit details
    Browse the repository at this point in the history

  6. Make sure that tinyxml2::tinyxml2 is available in downstream packages

    @traversaro
    traversaro authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a68d9a8 View commit details
    Browse the repository at this point in the history

  7. Update urdfdom-config.cmake.in

    @traversaro
    traversaro authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    bef2860 View commit details
    Browse the repository at this point in the history

  8. Replace InsertNewChildElement with GetDocument()->NewElement. 

    The former doesn't exist in older TinyXML2, and is just
a convenience function anyway.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a448c63 View commit details
    Browse the repository at this point in the history

  9. Remove another use of using tinyxml2. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    713e457 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'traversaro/patch-3' into tinyxml2

    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2c58e3f View commit details
    Browse the repository at this point in the history

  11. Fix generation of CMake config files. 

    Use the provided CMake primitives for this, which should
make it work in all situations.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b592bbd View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Install the FindTinyXML2.cmake file. 

    This is so downstream projects can always find it.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0e61d1f View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Backup and restore the CMAKE_MODULE_PATH. 

    So we don't permanently manipulate it.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    23ea44e View commit details
    Browse the repository at this point in the history