sonarcloud bug complain fix #8
Conversation
tests/04_00_02-fedchange.js
Outdated
| @@ -281,14 +281,14 @@ describe('RSK Federation change', function() { | |||
| await checkFederationAddedNewKeys(); | |||
| var addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); | |||
There was a problem hiding this comment.
| var addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); | |
| const addResultFirstCall = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); | |
| expect(Number(addResult)).to.equal(1); // First call successful |
Sonar is complaining because you declare this variable here but never use it, then declare it again as const.
I think the point of the test is to make the call twice, and check that the second time it fails. So we could also check the result of the first call
There was a problem hiding this comment.
ohh i fixed it before i read this comment, hope my naming is ok for you :)
There was a problem hiding this comment.
Naming is fine, but I would change it to const and also assert the result the first time
There was a problem hiding this comment.
hmm i'm not sure i understand, the assert was always there...
expect(Number(addKeysResult)).to.equal(-10); // not a public key
tests/04_00_02-fedchange.js
Outdated
| await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( | ||
|
|
||
| const addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( |
There was a problem hiding this comment.
| const addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( | |
| const addResultSecondCall = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( |
|
pipeline: run |
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.