Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: standard formatting #101

Merged
merged 20 commits into from
Feb 14, 2024
Merged

chore: standard formatting #101

merged 20 commits into from
Feb 14, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Jan 22, 2024 •
edited
Loading

Description of the change

Standard formatting

Resolves INT-1411

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Sai Sankeerth added 3 commits January 22, 2024 18:08
chore: standard formatting
3f19c49 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: updates for vscode IDE
5853c41 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: eslint comment updates & remove ignoring .vscode
d908256 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sanpj2292 sanpj2292 self-assigned this Jan 22, 2024
koladilip
koladilip previously approved these changes Jan 22, 2024
View reviewed changes
anantjain45823
anantjain45823 previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@anantjain45823 anantjain45823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chore: add test command & workflow to upload codecov, sonar reports
7986e16 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
Sai Sankeerth added 4 commits January 24, 2024 19:15
chore: add test-command as pre-commit hook
21c550a 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: include test-command in pre-commit command
671fee4 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: add husky related deps & scripts, pass jest with no tests, add…
07c544c 
… commitlint config

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: update sonarcloud related reports, pull request template
560e9ad 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sai Sankeerth added 9 commits January 31, 2024 16:25
chore: update report generation step & rename the workflow
def5679 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: move source-code to src folder, rename job names in tests-code…
b6f2f8e 
…-coverage workflow, add prettierignore

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: update sonar project name and key
a9c1214 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: remove testExecutionReportPaths
4e21ac3 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: sonar fixes - 1
444ba02 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: sonar fixes - 2
77186cd 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: sonar fixes - 3
add8c14 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: remove security risk by modifying regex
ef01139 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
chore: add commitlint workflow
17b1e09 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
koladilip
koladilip previously approved these changes Feb 5, 2024
View reviewed changes
koladilip
koladilip previously approved these changes Feb 12, 2024
View reviewed changes
fix: revert security sonar hotspot
0309096 
Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanpj2292 sanpj2292 merged commit e4a0f0a into develop Feb 14, 2024
4 checks passed
@sanpj2292 sanpj2292 deleted the chore.standard-format branch February 14, 2024 04:31
This was referenced Mar 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@utsabc utsabc Awaiting requested review from utsabc

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@krishna2020 krishna2020 Awaiting requested review from krishna2020

@anantjain45823 anantjain45823 Awaiting requested review from anantjain45823

Assignees

@sanpj2292 sanpj2292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanpj2292 @koladilip @anantjain45823