Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standard formatting #101

Merged
merged 20 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,22 @@ module.exports = {
es2021: true,
commonjs: true,
},
extends: ["prettier", "eslint:recommended", "plugin:json/recommended"],
extends: ['eslint:recommended', 'plugin:json/recommended', 'prettier'],
parserOptions: {
ecmaVersion: "latest",
sourceType: "module",
ecmaVersion: 'latest',
sourceType: 'module',
},
rules: {
'no-undef': 'warn',
'no-case-declarations': 'warn',
'no-unused-vars': [
'warn', // or "error"
{
argsIgnorePattern: '^_',
varsIgnorePattern: '^_',
caughtErrorsIgnorePattern: '^_',
},
],
'no-useless-escape': 'warn',
},
rules: {},
};
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ dist

# Stores VSCode versions used for testing VSCode extensions
.vscode-test
.vscode

# yarn v2
.yarn/cache
Expand All @@ -144,6 +143,5 @@ dist
.svelte-kit

# Others
**/.vscode

# End of https://www.toptal.com/developers/gitignore/api/node
24 changes: 24 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"prettier.requireConfig": true,
"prettier.configPath": ".prettierrc",
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
},
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
},
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
},
"[yaml]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
},
"editor.codeActionsOnSave": {
"source.organizeImports": "never"
},
"eslint.validate": ["javascript", "typescript"]
}
82 changes: 35 additions & 47 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,107 +8,95 @@ All notable changes to this project will be documented in this file. See [standa

### [1.4.7](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.6...v1.4.7) (2023-10-04)


### Bug Fixes

* Dockerfile to reduce vulnerabilities ([#42](https://github.com/rudderlabs/rudder-shopify-tracker/issues/42)) ([d782819](https://github.com/rudderlabs/rudder-shopify-tracker/commit/d7828193f4af4fcafefb96f553c6e52e80e86528))
- Dockerfile to reduce vulnerabilities ([#42](https://github.com/rudderlabs/rudder-shopify-tracker/issues/42)) ([d782819](https://github.com/rudderlabs/rudder-shopify-tracker/commit/d7828193f4af4fcafefb96f553c6e52e80e86528))

### [1.4.6](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.5...v1.4.6) (2023-09-26)


### Bug Fixes

* the release owners ([#82](https://github.com/rudderlabs/rudder-shopify-tracker/issues/82)) ([a312cdb](https://github.com/rudderlabs/rudder-shopify-tracker/commit/a312cdb9ef4fa591d1116e2b5ea245fb77d1cc5d))
- the release owners ([#82](https://github.com/rudderlabs/rudder-shopify-tracker/issues/82)) ([a312cdb](https://github.com/rudderlabs/rudder-shopify-tracker/commit/a312cdb9ef4fa591d1116e2b5ea245fb77d1cc5d))

### [1.4.5](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.4...v1.4.5) (2023-09-26)


### Bug Fixes

* formatting files ([#79](https://github.com/rudderlabs/rudder-shopify-tracker/issues/79)) ([8f6f771](https://github.com/rudderlabs/rudder-shopify-tracker/commit/8f6f77139a3d68bbf20f6284a8eda7e7c324f566))
- formatting files ([#79](https://github.com/rudderlabs/rudder-shopify-tracker/issues/79)) ([8f6f771](https://github.com/rudderlabs/rudder-shopify-tracker/commit/8f6f77139a3d68bbf20f6284a8eda7e7c324f566))

### [1.4.4](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.3...v1.4.4) (2023-09-26)

### [1.4.3](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.2...v1.4.3) (2023-09-26)


### Bug Fixes

* docker image tag ([#74](https://github.com/rudderlabs/rudder-shopify-tracker/issues/74)) ([673bf62](https://github.com/rudderlabs/rudder-shopify-tracker/commit/673bf6299890c757397734e5952b0b78552ce06c))
- docker image tag ([#74](https://github.com/rudderlabs/rudder-shopify-tracker/issues/74)) ([673bf62](https://github.com/rudderlabs/rudder-shopify-tracker/commit/673bf6299890c757397734e5952b0b78552ce06c))

### [1.4.2](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.1...v1.4.2) (2023-09-26)


### Bug Fixes

* forward secrets to workflows ([#71](https://github.com/rudderlabs/rudder-shopify-tracker/issues/71)) ([0bb3f6a](https://github.com/rudderlabs/rudder-shopify-tracker/commit/0bb3f6a2502749004d03b24416ddd0d095aa88a9))
- forward secrets to workflows ([#71](https://github.com/rudderlabs/rudder-shopify-tracker/issues/71)) ([0bb3f6a](https://github.com/rudderlabs/rudder-shopify-tracker/commit/0bb3f6a2502749004d03b24416ddd0d095aa88a9))

### [1.4.1](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.4.0...v1.4.1) (2023-09-26)


### Bug Fixes

* prod deploy workflow job ([#69](https://github.com/rudderlabs/rudder-shopify-tracker/issues/69)) ([52a638d](https://github.com/rudderlabs/rudder-shopify-tracker/commit/52a638d1d87c0a728fdc4273d1cf2a37f4445113))
- prod deploy workflow job ([#69](https://github.com/rudderlabs/rudder-shopify-tracker/issues/69)) ([52a638d](https://github.com/rudderlabs/rudder-shopify-tracker/commit/52a638d1d87c0a728fdc4273d1cf2a37f4445113))

## [1.4.0](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.3.0...v1.4.0) (2023-09-26)


### Features

* clean up prod deploy workflow ([#64](https://github.com/rudderlabs/rudder-shopify-tracker/issues/64)) ([6f1edb5](https://github.com/rudderlabs/rudder-shopify-tracker/commit/6f1edb517f87eb3b970907fe96b1aa220f37b0ec))
- clean up prod deploy workflow ([#64](https://github.com/rudderlabs/rudder-shopify-tracker/issues/64)) ([6f1edb5](https://github.com/rudderlabs/rudder-shopify-tracker/commit/6f1edb517f87eb3b970907fe96b1aa220f37b0ec))

## [1.3.0](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.2.2...v1.3.0) (2023-09-26)


### Features

* formatting file ([#61](https://github.com/rudderlabs/rudder-shopify-tracker/issues/61)) ([9775633](https://github.com/rudderlabs/rudder-shopify-tracker/commit/9775633f0f7cfc2d239147f502e521e7a25f2cc7))
- formatting file ([#61](https://github.com/rudderlabs/rudder-shopify-tracker/issues/61)) ([9775633](https://github.com/rudderlabs/rudder-shopify-tracker/commit/9775633f0f7cfc2d239147f502e521e7a25f2cc7))

### [1.2.2](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.2.1...v1.2.2) (2023-09-26)


### Bug Fixes

* prod deploy condition ([#58](https://github.com/rudderlabs/rudder-shopify-tracker/issues/58)) ([5d8bffc](https://github.com/rudderlabs/rudder-shopify-tracker/commit/5d8bffc9a5d4b9d82a6c43c1aea6a723f523b298))
- prod deploy condition ([#58](https://github.com/rudderlabs/rudder-shopify-tracker/issues/58)) ([5d8bffc](https://github.com/rudderlabs/rudder-shopify-tracker/commit/5d8bffc9a5d4b9d82a6c43c1aea6a723f523b298))

### [1.2.1](https://github.com/rudderlabs/rudder-shopify-tracker/compare/v1.2.0...v1.2.1) (2023-09-26)


### Bug Fixes

* prod deploy chronology ([#55](https://github.com/rudderlabs/rudder-shopify-tracker/issues/55)) ([894f038](https://github.com/rudderlabs/rudder-shopify-tracker/commit/894f038043addca9d7dd3e5f6f1ea1f9bb0d2336))
- prod deploy chronology ([#55](https://github.com/rudderlabs/rudder-shopify-tracker/issues/55)) ([894f038](https://github.com/rudderlabs/rudder-shopify-tracker/commit/894f038043addca9d7dd3e5f6f1ea1f9bb0d2336))

## 1.2.0 (2023-09-26)


### Features

* adding cartToken to rudderIdentifier payload ([1af7b1c](https://github.com/rudderlabs/rudder-shopify-tracker/commit/1af7b1c3672ea9a90bbab41793ef72ffd8d778a6))
* adding ci/cd to shopify tracker repository ([#43](https://github.com/rudderlabs/rudder-shopify-tracker/issues/43)) ([666f7e3](https://github.com/rudderlabs/rudder-shopify-tracker/commit/666f7e3288da7113b78e4141e05d0f475b97cc23))
* adding session Id stitching and upgrading node version to v18 ([#30](https://github.com/rudderlabs/rudder-shopify-tracker/issues/30)) ([dd8bc39](https://github.com/rudderlabs/rudder-shopify-tracker/commit/dd8bc39994da3f9c46c1b0d0cded1fc519b90454))
* address comment ([ff96b36](https://github.com/rudderlabs/rudder-shopify-tracker/commit/ff96b365f4c47d9c0dfacf27ec58d688009e68e6))
* fire Rudder Identifier Periodically ([f339eea](https://github.com/rudderlabs/rudder-shopify-tracker/commit/f339eea9cce2c3a14e282ad827ce4afc833946be))
* initial commit for identity stitching ([e536415](https://github.com/rudderlabs/rudder-shopify-tracker/commit/e5364156789ff3d7b014283a351a3bf3543884b1))
* refactor code ([56ce4a9](https://github.com/rudderlabs/rudder-shopify-tracker/commit/56ce4a92c967bbfdd3a2f55b5ee3234522159ecf))
* send whole cart payload for rudderIdentifier event ([8d2dabd](https://github.com/rudderlabs/rudder-shopify-tracker/commit/8d2dabd5556a832fe3d49ed4159d3dea26f57055))
* skip client side identify calls ([2e6cf0d](https://github.com/rudderlabs/rudder-shopify-tracker/commit/2e6cf0de98c50d348f1b346ed97b5dbe39c22445))
* storing cart attributes as cookie ([806d187](https://github.com/rudderlabs/rudder-shopify-tracker/commit/806d1875872c8a52947b5b011581525468f605c2))
* update product list viewed event call ([#28](https://github.com/rudderlabs/rudder-shopify-tracker/issues/28)) ([2b79208](https://github.com/rudderlabs/rudder-shopify-tracker/commit/2b792086ad8d89f33a812a19e290d1518ad27b04))

- adding cartToken to rudderIdentifier payload ([1af7b1c](https://github.com/rudderlabs/rudder-shopify-tracker/commit/1af7b1c3672ea9a90bbab41793ef72ffd8d778a6))
- adding ci/cd to shopify tracker repository ([#43](https://github.com/rudderlabs/rudder-shopify-tracker/issues/43)) ([666f7e3](https://github.com/rudderlabs/rudder-shopify-tracker/commit/666f7e3288da7113b78e4141e05d0f475b97cc23))
- adding session Id stitching and upgrading node version to v18 ([#30](https://github.com/rudderlabs/rudder-shopify-tracker/issues/30)) ([dd8bc39](https://github.com/rudderlabs/rudder-shopify-tracker/commit/dd8bc39994da3f9c46c1b0d0cded1fc519b90454))
- address comment ([ff96b36](https://github.com/rudderlabs/rudder-shopify-tracker/commit/ff96b365f4c47d9c0dfacf27ec58d688009e68e6))
- fire Rudder Identifier Periodically ([f339eea](https://github.com/rudderlabs/rudder-shopify-tracker/commit/f339eea9cce2c3a14e282ad827ce4afc833946be))
- initial commit for identity stitching ([e536415](https://github.com/rudderlabs/rudder-shopify-tracker/commit/e5364156789ff3d7b014283a351a3bf3543884b1))
- refactor code ([56ce4a9](https://github.com/rudderlabs/rudder-shopify-tracker/commit/56ce4a92c967bbfdd3a2f55b5ee3234522159ecf))
- send whole cart payload for rudderIdentifier event ([8d2dabd](https://github.com/rudderlabs/rudder-shopify-tracker/commit/8d2dabd5556a832fe3d49ed4159d3dea26f57055))
- skip client side identify calls ([2e6cf0d](https://github.com/rudderlabs/rudder-shopify-tracker/commit/2e6cf0de98c50d348f1b346ed97b5dbe39c22445))
- storing cart attributes as cookie ([806d187](https://github.com/rudderlabs/rudder-shopify-tracker/commit/806d1875872c8a52947b5b011581525468f605c2))
- update product list viewed event call ([#28](https://github.com/rudderlabs/rudder-shopify-tracker/issues/28)) ([2b79208](https://github.com/rudderlabs/rudder-shopify-tracker/commit/2b792086ad8d89f33a812a19e290d1518ad27b04))

### Bug Fixes

* ci/cd file name ([#50](https://github.com/rudderlabs/rudder-shopify-tracker/issues/50)) ([a77fdf9](https://github.com/rudderlabs/rudder-shopify-tracker/commit/a77fdf9d40471239cce1f10e4cffe064d365191c))
* cookie update check timeInterval ([17ce9a8](https://github.com/rudderlabs/rudder-shopify-tracker/commit/17ce9a88bdb335075e04e09df6f97d95a2c93f48))
* docker file name ([#52](https://github.com/rudderlabs/rudder-shopify-tracker/issues/52)) ([b20c4b6](https://github.com/rudderlabs/rudder-shopify-tracker/commit/b20c4b617797683cd5281d19a85e13cb32f80be0))
* double product clicked events ([#37](https://github.com/rudderlabs/rudder-shopify-tracker/issues/37)) ([2b8fec3](https://github.com/rudderlabs/rudder-shopify-tracker/commit/2b8fec31f505ea12a98b9637c7c96b869ebcd8b5))
* Fire Product Added Event for multiple add to cart buttons ([48d3446](https://github.com/rudderlabs/rudder-shopify-tracker/commit/48d3446116454c32bbb3c8a9e6f5ceb896591563))
* make deviceModeInit variable as a scope variable ([da329e9](https://github.com/rudderlabs/rudder-shopify-tracker/commit/da329e95790dac3515a9de6ad5a2babdb8f69428))
* product list view and product clicked enhancement ([#38](https://github.com/rudderlabs/rudder-shopify-tracker/issues/38)) ([103620b](https://github.com/rudderlabs/rudder-shopify-tracker/commit/103620b775e2af119198101dc554595afba3bcda)), closes [#39](https://github.com/rudderlabs/rudder-shopify-tracker/issues/39)
* remove extra commit ([99cbeef](https://github.com/rudderlabs/rudder-shopify-tracker/commit/99cbeef4649b3e708053fcf169687d9b7b9a8b84))
* removing anonymousId from cookie ([126a7d8](https://github.com/rudderlabs/rudder-shopify-tracker/commit/126a7d85e857e4e70b50a358b30032f4ef01e2fa))
* replace replaceAll() with regex ([c99122e](https://github.com/rudderlabs/rudder-shopify-tracker/commit/c99122e46241b02f85eaaf156643296358ff119c))
* reset analytics when user logs out to reset cache ([#35](https://github.com/rudderlabs/rudder-shopify-tracker/issues/35)) ([b241815](https://github.com/rudderlabs/rudder-shopify-tracker/commit/b2418156f844bab9005a5dad92082ee39488a809))
* sending cart object in identifier event ([6a55175](https://github.com/rudderlabs/rudder-shopify-tracker/commit/6a55175040b9e2d5f40ab2ac2ffb97dbf6e1e56a))
* sku value to be non amalgamated, depends on variant ([#24](https://github.com/rudderlabs/rudder-shopify-tracker/issues/24)) ([b3c051f](https://github.com/rudderlabs/rudder-shopify-tracker/commit/b3c051fc44d4a2a2c701e45801a8f69ed3d59ad5))
* stringify product_id before using in sku ([#27](https://github.com/rudderlabs/rudder-shopify-tracker/issues/27)) ([e9626d6](https://github.com/rudderlabs/rudder-shopify-tracker/commit/e9626d6ef602a23b9170cb0d260bae4882856f3e))
- ci/cd file name ([#50](https://github.com/rudderlabs/rudder-shopify-tracker/issues/50)) ([a77fdf9](https://github.com/rudderlabs/rudder-shopify-tracker/commit/a77fdf9d40471239cce1f10e4cffe064d365191c))
- cookie update check timeInterval ([17ce9a8](https://github.com/rudderlabs/rudder-shopify-tracker/commit/17ce9a88bdb335075e04e09df6f97d95a2c93f48))
- docker file name ([#52](https://github.com/rudderlabs/rudder-shopify-tracker/issues/52)) ([b20c4b6](https://github.com/rudderlabs/rudder-shopify-tracker/commit/b20c4b617797683cd5281d19a85e13cb32f80be0))
- double product clicked events ([#37](https://github.com/rudderlabs/rudder-shopify-tracker/issues/37)) ([2b8fec3](https://github.com/rudderlabs/rudder-shopify-tracker/commit/2b8fec31f505ea12a98b9637c7c96b869ebcd8b5))
- Fire Product Added Event for multiple add to cart buttons ([48d3446](https://github.com/rudderlabs/rudder-shopify-tracker/commit/48d3446116454c32bbb3c8a9e6f5ceb896591563))
- make deviceModeInit variable as a scope variable ([da329e9](https://github.com/rudderlabs/rudder-shopify-tracker/commit/da329e95790dac3515a9de6ad5a2babdb8f69428))
- product list view and product clicked enhancement ([#38](https://github.com/rudderlabs/rudder-shopify-tracker/issues/38)) ([103620b](https://github.com/rudderlabs/rudder-shopify-tracker/commit/103620b775e2af119198101dc554595afba3bcda)), closes [#39](https://github.com/rudderlabs/rudder-shopify-tracker/issues/39)
- remove extra commit ([99cbeef](https://github.com/rudderlabs/rudder-shopify-tracker/commit/99cbeef4649b3e708053fcf169687d9b7b9a8b84))
- removing anonymousId from cookie ([126a7d8](https://github.com/rudderlabs/rudder-shopify-tracker/commit/126a7d85e857e4e70b50a358b30032f4ef01e2fa))
- replace replaceAll() with regex ([c99122e](https://github.com/rudderlabs/rudder-shopify-tracker/commit/c99122e46241b02f85eaaf156643296358ff119c))
- reset analytics when user logs out to reset cache ([#35](https://github.com/rudderlabs/rudder-shopify-tracker/issues/35)) ([b241815](https://github.com/rudderlabs/rudder-shopify-tracker/commit/b2418156f844bab9005a5dad92082ee39488a809))
- sending cart object in identifier event ([6a55175](https://github.com/rudderlabs/rudder-shopify-tracker/commit/6a55175040b9e2d5f40ab2ac2ffb97dbf6e1e56a))
- sku value to be non amalgamated, depends on variant ([#24](https://github.com/rudderlabs/rudder-shopify-tracker/issues/24)) ([b3c051f](https://github.com/rudderlabs/rudder-shopify-tracker/commit/b3c051fc44d4a2a2c701e45801a8f69ed3d59ad5))
- stringify product_id before using in sku ([#27](https://github.com/rudderlabs/rudder-shopify-tracker/issues/27)) ([e9626d6](https://github.com/rudderlabs/rudder-shopify-tracker/commit/e9626d6ef602a23b9170cb0d260bae4882856f3e))
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,19 @@
This application lets you connect your Shopify store with RudderStack. Use it to track event-level data from Shopify and send it to your preferred tooling platforms via RudderStack.

## Overview

This repo is a component of RudderStack Shopify App (https://github.com/rudderlabs/rudderstack-shopify-app). The shoppify-app node server makes a request to this server with dataplane url and writekey. This server returns a wrapper on top of our js-sdk for client-side tracking for the shopify stores.

### Get Started

This is simple node server with koa router. Steps to run locally:
1. ```npm install```
2. ```npm run start```

1. `npm install`
2. `npm run start`

## Features
It is a smart tracking script which inserts into the Shopify store pages, and allows client-side tracking. Please note, this works in conjunction to the above-mentioned RudderStack Shopify App.

It is a smart tracking script which inserts into the Shopify store pages, and allows client-side tracking. Please note, this works in conjunction to the above-mentioned RudderStack Shopify App.

<!-- ## Getting started
### Pre-requisites
Expand Down
8 changes: 2 additions & 6 deletions commitlnt.config.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
module.exports = {
extends: ["@commitlint/config-conventional"],
extends: ['@commitlint/config-conventional'],
rules: {
"type-enum": () => [
2,
"always",
["fix", "feat", "chore", "refactor", "docs", "test"],
],
'type-enum': () => [2, 'always', ['fix', 'feat', 'chore', 'refactor', 'docs', 'test']],
},
};
Loading