Clean up the hashes dependency/feature #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
07-14-hashes-dep
branch
3 times, most recently
from
8f94237
to
446e045
Compare
elichai
reviewed
Jul 19, 2023
| @@ -21,8 +21,7 @@ default = ["std"] | |||
| std = ["alloc", "secp256k1-sys/std"] | |||
| # allow use of Secp256k1::new and related API that requires an allocator | |||
| alloc = ["secp256k1-sys/alloc"] | |||
| bitcoin-hashes = ["bitcoin_hashes"] # Feature alias because of the underscore. | |||
| bitcoin-hashes-std = ["std", "bitcoin_hashes", "bitcoin_hashes/std"] | |||
| hashes-std = ["std", "hashes/std"] | |||
There was a problem hiding this comment.
Whenever we hit MSRV 1.60 we can replace all the -std ones with:
std = ["hashes?/std"]
There was a problem hiding this comment.
Already tracked here: rust-bitcoin/rust-bitcoin#1722 but thanks for mentioning, I didn't actually know what "weak dependencies" meant - TIL.
apoelstra
reviewed
Jul 19, 2023
tcharding
force-pushed
the
07-14-hashes-dep
branch
2 times, most recently
from
299952b
to
c5279be
Compare
tcharding
force-pushed
the
07-14-hashes-dep
branch
from
c5279be
to
fca3cd3
Compare
tcharding
force-pushed
the
07-14-hashes-dep
branch
2 times, most recently
from
dd78b87
to
a522bf2
Compare
tcharding
force-pushed
the
07-14-hashes-dep
branch
from
a522bf2
to
834d9ea
Compare
|
I botched the rebase, will fix tomorrow. |
tcharding
force-pushed
the
07-14-hashes-dep
branch
4 times, most recently
from
6cec5e7
to
c965c94
Compare
Use the more terse `hashes` by way of the `package` field in the manifest. Allows us to remove the ugly feature alias "bitcoin-hashes" -> "bitcoin_hashes" and removes all the bother with the underscore. Why did we not think of this 2 years ago?
Now that we have `hashes` as the crate name of `bitcoin_hashes` we can slightly clean up the import statements. This is based on the convention we have to import things directly from the crate if we depend on it and not from the crate level re-export.
tcharding
force-pushed
the
07-14-hashes-dep
branch
from
c965c94
to
6fdd3b1
Compare
apoelstra
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the more terse
hashesby way of thepackagefield in the manifest.Allows us to remove the ugly feature alias "bitcoin-hashes" -> "bitcoin_hashes" and removes all the bother with the underscore.