Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the hashes dependency/feature #628

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Clean up the hashes dependency/feature #628

merged 2 commits into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. Use hashes instead of bitcoin_hashes 

    Use the more terse `hashes` by way of the `package` field in the
manifest.

Allows us to remove the ugly feature alias "bitcoin-hashes" ->
"bitcoin_hashes" and removes all the bother with the underscore.

Why did we not think of this 2 years ago?
    @tcharding
    tcharding committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6d7c653 View commit details
    Browse the repository at this point in the history

  2. Clean up hashes import statements 

    Now that we have `hashes` as the crate name of `bitcoin_hashes` we can
slightly clean up the import statements.

This is based on the convention we have to import things directly from
the crate if we depend on it and not from the crate level re-export.
    @tcharding
    tcharding committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6fdd3b1 View commit details
    Browse the repository at this point in the history