Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Seq2Seq Decoder #45

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Generic Seq2Seq Decoder #45

wants to merge 34 commits into from

Conversation

ZhouW321
Copy link
Contributor

@ZhouW321 ZhouW321 commented Feb 22, 2023

might still run auto clang formatting

@ZhouW321 ZhouW321 changed the title Generic seq2seq decoder Generic Seq2Seq Decoder Feb 22, 2023
@curufinwe
Copy link
Contributor

curufinwe commented Mar 28, 2023

Plan for review (discussed between @SimBe195 and @curufinwe ):
We review and merge in 6 steps. All of the code can be reviewed but we will try to merge different parts separately.

  1. small stuff (Bliss + Flf + Lattice + Speech (except aligner) + Tensorflow + Search/AdvancedTreeSearch+ Tools + Test), in addition we add a basic module without much functionality (Makefile + Module class) in order for the Makefile changes in other places to make sense.
  2. LabelScorer + other changes in Nn
  3. Search/
  4. S2STS/LabelTree
  5. S2STS rest except aligner
  6. aligner

For each step we create a separate PR and once changes are done and merged we apply them back into this PR.

Time estimates:

  1. 1-2 weeks
  2. 1-2 weeks
  3. 1 week
  4. 1 week
  5. 2-3 weeks
  6. 1 week

Total: 7-10 weeks or around 3 months

Next deadline: step 1 should be finished April 7th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants