-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Seq2Seq Decoder #45
Open
ZhouW321
wants to merge
34
commits into
master
Choose a base branch
from
generic-seq2seq-decoder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan for review (discussed between @SimBe195 and @curufinwe ):
For each step we create a separate PR and once changes are done and merged we apply them back into this PR. Time estimates:
Total: 7-10 weeks or around 3 months Next deadline: step 1 should be finished April 7th |
ZhouW321
force-pushed
the
generic-seq2seq-decoder
branch
from
January 24, 2024 16:23
0254d22
to
7ddf3d2
Compare
ZhouW321
force-pushed
the
generic-seq2seq-decoder
branch
from
January 24, 2024 18:21
b4f8b9b
to
83307a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might still run auto clang formatting