🐛 CollectionResources x Thumbnails: Alt text doesn't work

[ShanaLMoore]

Summary

Acceptance Criteria

• A user should be able to upload a banner, logo, and thumbnail to a collection, from the collection edit page
• the banner, logo and thumbnail should be able to support alt text, if set

Screenshots or Video

collections can no longer upload a thumbnail. After creating a collection, a user used to be able to upload a thumbnail on edit.

It should look like:

Testing Instructions

• On DEMO, Login as admin
• Create a New User Collection
• After clicking save, the edit page should have a "Branding" tab. Click it, and notice the "Thumbnail" section at the bottom of the form
• Upload an image and save. Note, Alt Text may look out of place - this is a known bug and considered a separate issue. Alt text is optional - enter it if you'd like.
• Click Collections in the sidebar to view all the collections (index page)
• The thumbnail should appear and match the file you just uploaded
• If you entered alt text, you should see if when you inspect the thumbnail element of that page. ie: see eddie-baby-alt-text

Results checklist

(verifying both branding AND default thumbnails, since they interact)

• Setting Branding
  • Images and text can be set and will appear on collection's branding tab
  • Images and text can be removed and disappear from collection's branding tab
  • Branding shows appropriately on collection's public show page
  • Branding reverts to standard when removed from collection's branding tab
  • Note that banner alt-text appears in title, as background images cannot support alt-text.
• Setting Default thumbnails
  • Default thumbnails and alt text are saved and appear on Settings/Appearance default images tab
  • Default thumbnails and text can be removed and disappear from Settings/Appearance default images tab
  • Setting a default thumbnail or text reindexes all works &/or collections, and results in all collections or works showing new default thumbnails appropriately
  • Removing a collection's default thumbnail does not affect works
  • Removing a work's default thumbnail does not affect collections
• Thumbnails show appropriately on all views:
  • catalog search results view
  • dashboard index views
  • collection public show
  • collection dashboard show
  • homepage featured collections

Notes

ref:

• Valkyrie: Edit collection using PcdmCollection raises exception undefined thumbnail_id samvera/hyrax#5286

[ShanaLMoore]

https://samvera.slack.com/archives/CA8ANGLEL/p1714575345096909

[ShanaLMoore]

We will implement this the way that collection logos and banners got implemented.

ref: samvera/hyrax@22f0d64#diff-69953ce87573380937a88812d601159110a97da5b1621ebc79b7460f0cbb3ae5

[ShanaLMoore]

BLOCKED from QA until Shana updates testing instructions

[ShanaLMoore]

QA Results: Needs Rework ❌

Uploading branding images are not loading in the UI.

Example: https://demo.hyku-demo.notch8.cloud/dashboard/collections/5cd101a4-e698-4141-8c02-8976e14efe49?locale=en

Image Not Found error message. This works locally so I think it's a server issue. I tried adding a persistent volume in this PR

These two paths needs to be symlinked:

[ShanaLMoore]

UPDATED: the latest deploy renders the upload, but the thumbnails still don't show

[ShanaLMoore]

The issue seems to be whatever is responsible for indexing thumbnail_path_ss

staging data:

 "thumbnail_path_ss"=>"/app/samvera/branding/5cd101a4-e698-4141-8c02-8976e14efe49/thumbnail/eddie-baby.jpg",

this should remove app/samvera

[jillpe]

SoftServ QA: ❌ Needs Rework - saved alt text does not display in various pages

'Thumbnail' section is present in the branding tab ✅

Collection Created

thumbnail displays but the alt text is not present in the dashboard collection page view, public collection show page view, or the catalog search view. The catalog search results thumbnail also overlaps text ❌

[ShanaLMoore]

[jillpe]

Blocked until knapsack is updated

[jillpe]

SoftServ QA: ✅

[ShanaLMoore]

issues noticed internally when QA-ing collection branding. client verification is not needed.