-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: current failing jax tests for jax>=0.4.36
#3340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfackeldey - Thanks for prompt fix! Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this fixes the tests! But it's a good example of how hard it is to work with JAX: jax.config.update
is not in our control. It only takes effect if it is the first thing that's called after importing JAX. After that time, it's silently ignored!
(#3333 is now merged, if you were waiting) |
The jobs in #3333 are still required, so non-admins can no longer merge. Why was that job removed? |
The WASM-building job in docs.yml was removed because it was building a WASM version of awkward-cpp for the documentation, but the documentation no longer includes an embedded JupyterLite iframe. (Instead, the "try it" button points to a raw-Pyodide page that gets awkward-cpp from the web.) I don't know how #3333 passed if that's still required. I don't remember it waiting for that reason. But I'll remove the requirement now. |
This PR fixes the current failing JAX tests since jax version 0.4.36. It adds a flag to restore old (jax<0.4.36) tracing behavior, see more at: https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-36-dec-5-2024
At some point we likely want to address this properly, but for now this should make our jax tests pass again.