(WIP) Prototype for clone-free Expression
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Constant poly | ||
| Constant(E::BaseField), | ||
| /// This is the sum of two Expr | ||
| Sum(CompoundExpr<'a, E>, CompoundExpr<'a, E>), |
There was a problem hiding this comment.
No Boxes here!
| /// Contains a reference to [`ExprTree`] that is managed by [`ExprBuilder`]. | ||
| #[derive(Clone, Copy, Debug)] | ||
| pub enum Expr<'a, E: ExtensionField> { | ||
| Constant(E::BaseField), |
There was a problem hiding this comment.
The enum is for convenience, so you don't need a 'builder' for constants. The whole thing would also work without.
| } | ||
|
|
||
| #[derive(Clone, Copy, Debug)] | ||
| pub struct CompoundExpr<'a, E: ExtensionField>(&'a ExprTree<'a, E>); |
There was a problem hiding this comment.
We need this extra wrapper here to keep Rust's type system happy. For some reason you can't just write Sum(&'a ExprTree<'a, E>, &'a ExprTree<'a, E>), in the definition of ExprTree and have it work.
(This wrapper shouldn't have any runtime impact.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with readability. We want to cut down on visual noise, so that it'll be easier for us and any auditor (and enthusiasts, once this is open sourced) to spot problems with the constraints. Or otherwise convince themselves that there are no problem with the constraints.
In theory, the new approach can be ever so slightly faster, but I don't think it makes much of a difference performance-wise. The technique is borrowed from what the Rust compiler uses internally.