Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structurize, update and extend the documentation #2188

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Nov 15, 2024

Description of your changes:
This PR isn't fixing all the docs issues we have but it's an attempt to:

  • make the documentation hierarchical
  • fix or remove the pages that are incorrect
  • fix the outdated steps that don't apply anymore
  • describe the overall architecture
  • describe the components and install flow
  • describe the GitOps flow (although that could be simplified by publishing the manifests e.g. to GH releases - this just describes how it's done today)
  • describe at least the basics of how storage is set up
  • avoid requiring users to clone the operator repository
  • gets rid of using the unsupported demo scrips (we don't want to be in the business of teaching people Kubernetes set up or automation), although we have retained the simple set up idea with quickstarts that have just a single path to start with
  • add a few diagrams
  • slightly better UX for copy pasting and other small things here and there
  • and some more that I could fit into the limited cycles I had allocated

Which issue is resolved by this Pull Request:
Resolves #1578 (and more)

Requires

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 15, 2024
@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2024
@tnozicka tnozicka changed the title [WIP] Structurize, update and extend the documentation Structurize, update and extend the documentation Nov 18, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@tnozicka
Copy link
Member Author

tnozicka commented Nov 18, 2024

/hold
to test the flows before merging it (if we agree that this is how we do it in review)

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@tnozicka tnozicka changed the title Structurize, update and extend the documentation [WIP] Structurize, update and extend the documentation Nov 19, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@tnozicka tnozicka force-pushed the doc-refresh branch 3 times, most recently from f4b8a28 to aa8b65b Compare November 19, 2024 08:24
@tnozicka tnozicka changed the title [WIP] Structurize, update and extend the documentation Structurize, update and extend the documentation Nov 19, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@tnozicka tnozicka force-pushed the doc-refresh branch 2 times, most recently from 0c804b7 to 0cc84d4 Compare November 19, 2024 11:59
docs/source/resources/scyllaclusters/basics.md Outdated Show resolved Hide resolved
docs/source/architecture/storage/overview.md Outdated Show resolved Hide resolved
docs/source/architecture/storage/local-csi-driver.md Outdated Show resolved Hide resolved
docs/source/architecture/tuning.md Outdated Show resolved Hide resolved
docs/source/architecture/manager.md Outdated Show resolved Hide resolved
docs/source/architecture/manager.md Outdated Show resolved Hide resolved
docs/source/installation/overview.md Outdated Show resolved Hide resolved
docs/source/resources/scyllaclusters/basics.md Outdated Show resolved Hide resolved
@rzetelskik
Copy link
Member

It fails building locally for me

/go/github.com/scylladb/scylla-operator/docs/source/resources/scylladbmonitorings.md:7: WARNING: Include file '/go/github.com/scylladb/scylla-operator/examples/monitoring/v1alpha1/scylladbmonitoring.yaml' not found or reading it failed [docutils]
...
sphinx-sitemap: sitemap.xml was generated for URL https://operator.docs.scylladb.com in /go/github.com/scylladb/scylla-operator/docs/_build/dirhtml/sitemap.xml
build finished with problems, 1 warning (with warnings treated as errors).
make: *** [Makefile:37: dirhtml] Error 1

command in README-dev.md should be updated with -v="$( pwd )/examples:/go/$( go list -m )/examples:Z"

preferably to:

podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" -v="$( pwd )/examples:/go/$( go list -m )/examples:Z"  --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.8 bash -euExo pipefail -O inherit_errexit -c 'poetry install && make --warn-undefined-variables dirhtml SPHINXOPTS="--keep-going" && make --warn-undefined-variables redirects && make preview'

to make it closer to what we do in CI

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign rzetelskik

Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two conversations remaining, rest lgtm

@tnozicka tnozicka force-pushed the doc-refresh branch 2 times, most recently from 9ba7fc1 to dc3a9a0 Compare November 22, 2024 12:02
@rzetelskik
Copy link
Member

/lgtm
thanks for the updates

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@tnozicka
Copy link
Member Author

I am testing the quickstarts - pushed a few fixes as well as using a bit smaller machines so it gets through with default GKE quotas (that I've also hit).

@tnozicka tnozicka force-pushed the doc-refresh branch 2 times, most recently from bdf03f2 to 5d7e1f8 Compare November 22, 2024 16:06
@tnozicka
Copy link
Member Author

tnozicka commented Nov 22, 2024

ok, the GKE went fine, I need to try EKS again next week (it failed spinning up today)

@tnozicka
Copy link
Member Author

well, the EKS got as far as expected given EKS is broken with current master

    - lastTransitionTime: "2024-11-25T09:38:14Z"
      message: 'can''t create mounts: can''t ensure units: can''t get unit statuses:
        can''t list units by names "mnt-persistent\\x2dvolumes.mount": Unknown method
        ''ListUnitsByNames'' or interface ''org.freedesktop.systemd1.Manager''.'

#2180

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentations enhancements [Part 1]
3 participants