-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structurize, update and extend the documentation #2188
Conversation
de5ea60
to
b7002d5
Compare
b7002d5
to
2e78b92
Compare
/hold |
f4b8a28
to
aa8b65b
Compare
0c804b7
to
0cc84d4
Compare
0cc84d4
to
9dcb8d3
Compare
It fails building locally for me
command in README-dev.md should be updated with preferably to:
to make it closer to what we do in CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign rzetelskik
9dcb8d3
to
7e43c66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two conversations remaining, rest lgtm
9ba7fc1
to
dc3a9a0
Compare
/lgtm |
dc3a9a0
to
1e8d6cb
Compare
I am testing the quickstarts - pushed a few fixes as well as using a bit smaller machines so it gets through with default GKE quotas (that I've also hit). |
bdf03f2
to
5d7e1f8
Compare
5d7e1f8
to
6bf7aa5
Compare
ok, the GKE went fine, I need to try EKS again next week (it failed spinning up today) |
well, the EKS got as far as expected given EKS is broken with current master
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
This PR isn't fixing all the docs issues we have but it's an attempt to:
Which issue is resolved by this Pull Request:
Resolves #1578 (and more)
Requires