Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display warning when access-code is being removed #650

Merged
merged 23 commits into from
Jul 25, 2024

Conversation

louis-pre
Copy link
Contributor

@louis-pre louis-pre commented Jul 24, 2024

Context

#449
#651

Changes

New

  • Gray out access-code rows when their status is "removing"
  • Show a warning in the access-code details view when the access-code's status is "removing"
  • Disable edit and delete actions when access-code is in "removing" state
  • Optimistically mark access-codes as "removing" when the deletion query is successful
  • Show snackbar when access code is deleted
  • New props to be able to control onDelete for AccessCodeDetails

Fixes

  • Fix a bug that kept a wrong state for the access-code row menu when closed (reopening it would show the deletion menu instead of the normal menu)
  • Fix bug where the AccessCodeDetails was missing a nested edit form
  • Circumvent bug with snackbar that causes the wrong message to be displayed temporarily

Images

Screenshot 2024-07-23 at 5 39 27 PM Screenshot 2024-07-23 at 5 39 43 PM

<div className='seam-heading'>{t.id}:</div>
<div className='seam-content seam-code-id'>
<span>{accessCode.access_code_id}</span>
<>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code got indented

@louis-pre louis-pre force-pushed the feat/449-delete-access-code branch from a484596 to 3d15037 Compare July 25, 2024 22:27
@louis-pre louis-pre marked this pull request as ready for review July 25, 2024 22:39
@louis-pre louis-pre requested a review from razor-x July 25, 2024 22:39
@louis-pre louis-pre changed the title feat: Display warning when access-code is being removed Display warning when access-code is being removed Jul 25, 2024
@louis-pre louis-pre merged commit 70b1515 into main Jul 25, 2024
16 checks passed
@louis-pre louis-pre deleted the feat/449-delete-access-code branch July 25, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants