Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning when access-code is being removed #650

Merged
merged 23 commits into from
Jul 25, 2024
Merged

Display warning when access-code is being removed #650

merged 23 commits into from
Jul 25, 2024

Commits on Jul 25, 2024

  1. fix: Improve access code deletion menu UX

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    513e46d View commit details
    Browse the repository at this point in the history

  2. feat: Display warning when access code is being removed

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    b9ad9ac View commit details
    Browse the repository at this point in the history

  3. Fix some types

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f8d9644 View commit details
    Browse the repository at this point in the history

  4. Add missing props to AccessCodeDetails.element

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    511c2a5 View commit details
    Browse the repository at this point in the history

  5. Rename isBeingRemoved to isAccessCodeBeingRemoved

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1ce0ec5 View commit details
    Browse the repository at this point in the history

  6. feat: Add snackbar when access code is being removed

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1b05418 View commit details
    Browse the repository at this point in the history

  7. Consider a missing access code as an access code being removed

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    35fd787 View commit details
    Browse the repository at this point in the history

  8. Use react-query state instead of custom state

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ace9ea6 View commit details
    Browse the repository at this point in the history

  9. Remove isEnabled prop from useAccessCode

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    72c3bcf View commit details
    Browse the repository at this point in the history

  10. Use class to apply grayed out style

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e6ad0e6 View commit details
    Browse the repository at this point in the history

  11. Do not show warning icon when being removed

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f0ac663 View commit details
    Browse the repository at this point in the history

  12. Rename onDelete to onDeleteSuccess

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    469c9a5 View commit details
    Browse the repository at this point in the history

  13. feat: Add storybook entry for access code being removed

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    00f18b0 View commit details
    Browse the repository at this point in the history

  14. fix: Snackbar would display default message when it should not

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9bb0300 View commit details
    Browse the repository at this point in the history

  15. Use empty string as default snackbar message

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    aa4548a View commit details
    Browse the repository at this point in the history

  16. Move private functions below component

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cf9ba25 View commit details
    Browse the repository at this point in the history

  17. Move disabling logic within AccessCodeMenu

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    31c7d67 View commit details
    Browse the repository at this point in the history

  18. Use proper logic to disable menu items

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3cc8043 View commit details
    Browse the repository at this point in the history

  19. Rename handler

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3842a62 View commit details
    Browse the repository at this point in the history

  20. feat: Add nested edit form to access code details component

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e46a3b6 View commit details
    Browse the repository at this point in the history

  21. Move snackbar logic to AccessCodeDetails

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    676b44b View commit details
    Browse the repository at this point in the history

  22. feat: Make AccessCodeDetails.onDelete configurable

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3d15037 View commit details
    Browse the repository at this point in the history

  23. Add missing effect dep

    @louis-pre
    louis-pre committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    43217e1 View commit details
    Browse the repository at this point in the history