Initial skeleton project #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
Nov 22, 2023
| exclude_dirs = ["tests"] | ||
|
|
||
| [tool.black] | ||
| line-length = 100 |
There was a problem hiding this comment.
I'm proposing 100 as a future compromise length, but no need to agree now - I'm happy to experiment with it
There was a problem hiding this comment.
ok, i will agree to not agree now ;P
real talk - i don't feel a need to standardize this, the defacto repo owner can pick. I do think 120 is too much, 100 is still wider than I'd choose but it's livable.
mikix
force-pushed
the
mikix/initial
branch
2 times, most recently
from
eea2014 to
bc4f1ee
Compare
mikix
commented
Nov 22, 2023
cumulus_fhir_support/schemas.py
Outdated
There was a problem hiding this comment.
This was basically copied wholesale from cumulus-etl
dogversioning
approved these changes
Nov 22, 2023
| exclude_dirs = ["tests"] | ||
|
|
||
| [tool.black] | ||
| line-length = 100 |
There was a problem hiding this comment.
ok, i will agree to not agree now ;P
real talk - i don't feel a need to standardize this, the defacto repo owner can pick. I do think 120 is too much, 100 is still wider than I'd choose but it's livable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.