Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with jumps #150

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Fix issues with jumps #150

merged 3 commits into from
Sep 4, 2024

Conversation

soininen
Copy link
Contributor

@soininen soininen commented Sep 3, 2024 •
edited
Loading

This PR fixes two separate issues with jumps:

  • The execution manager would execute forever if the engine was stopped by user.
  • Jump and all its items would be executed even when only the source item was selected. We should execute jumps only if all its items are selected for execution.

Fixes spine-tools/Spine-Toolbox#2925

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@soininen
Move Jump's default condition to class level field, add unit test
ce1e5cd 
No functional changes intended. I was hunting a transient bug in
Jump which turned out to be a "feature" when executing jumps under
PyCharm's debugger.

Re spine-tools/Spine-Toolbox#2925
@soininen
Propagate step failure to executor
6876546 
MultithreadExecutor.execute() must be notified if a step fails e.g.
due to user stopping the engine, otherwise it may end up looping
forever trying to execute items after Jumps that never finish.

Re spine-tools/Spine-Toolbox#2925
@soininen
Don't jump if any of jump's items isn't permitted to execute
6ba35fc 
Re spine-tools/Spine-Toolbox#2925
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (4fa66a3) to head (6ba35fc).

Files with missing lines Patch % Lines
spine_engine/spine_engine.py 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   62.69%   63.76%   +1.06%     
==========================================
  Files          40       40              
  Lines        3855     3858       +3     
  Branches      767      768       +1     
==========================================
+ Hits         2417     2460      +43     
+ Misses       1290     1256      -34     
+ Partials      148      142       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 965a60e into master Sep 4, 2024
14 checks passed
@soininen soininen deleted the toolbox_2925_fix_jump_cmd_line_args branch September 4, 2024 05:33
@soininen soininen mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stopping execution with loop leaves some process alive
1 participant
@soininen