Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with jumps #150

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Fix issues with jumps #150

merged 3 commits into from
Sep 4, 2024

Commits on Sep 2, 2024

  1. Move Jump's default condition to class level field, add unit test 

    No functional changes intended. I was hunting a transient bug in
Jump which turned out to be a "feature" when executing jumps under
PyCharm's debugger.

Re spine-tools/Spine-Toolbox#2925
    @soininen
    soininen committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ce1e5cd View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Propagate step failure to executor 

    MultithreadExecutor.execute() must be notified if a step fails e.g.
due to user stopping the engine, otherwise it may end up looping
forever trying to execute items after Jumps that never finish.

Re spine-tools/Spine-Toolbox#2925
    @soininen
    soininen committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6876546 View commit details
    Browse the repository at this point in the history

  2. Don't jump if any of jump's items isn't permitted to execute 

    Re spine-tools/Spine-Toolbox#2925
    @soininen
    soininen committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6ba35fc View commit details
    Browse the repository at this point in the history