Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Use flytectl sanbox for e2e testing #1016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ckiosidis
Copy link
Contributor

@ckiosidis ckiosidis commented Dec 13, 2022

Hey, I just made a Pull Request!

use flytectl sandbox for e2e tests

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@ckiosidis ckiosidis force-pushed the use-flytectl-sanbox-for-e2e-testing branch 6 times, most recently from 76f3d01 to ff23497 Compare December 13, 2022 14:04
@ckiosidis ckiosidis force-pushed the use-flytectl-sanbox-for-e2e-testing branch from ff23497 to 67e12a0 Compare December 13, 2022 14:09
@ckiosidis
Copy link
Contributor Author

ckiosidis commented Dec 15, 2022

circleci does not come with docker installed and uses a remote docker when enabled. I am not sure if this is going to work without making changes to flytectl to support a remote docker

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant