Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Use flytectl sanbox for e2e testing #1016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use flytectl sanbox for e2e testing #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2a1721
start and use sandbox
ckiosidis Dec 13, 2022
78061aa
run e2e tests
ckiosidis Dec 13, 2022
67e12a0
Fix curl
ckiosidis Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ jobs:
chmod +x grpc_health/grpc_health_probe
echo 'dc5c8cd7b33ef503f49eb639af6017f33d340884 grpc_health/grpc_health_probe' > .grpc_checksum
sha1sum -c .grpc_checksum
- setup_remote_docker:
version: 20.10.14
- run:
name: Tests
environment:
Expand All @@ -62,9 +64,9 @@ jobs:
# Maven heap size
MAVEN_OPTS: -Xmx256m -Xms256m
command: |
google-cloud-sdk/bin/kubectl -n flyte port-forward deployment/flyteadmin 8089:8089 &
# it takes some time for the portforwarding to be ready
grpc_health/grpc_health_probe -addr 127.0.0.1:8089 -connect-timeout 8s
curl -kL https://ctl.flyte.org/install | bash
./bin/flytectl sandbox start --dev
./bin/flytectl register examples -d development -p flytesnacks --config ~/.flyte/config-sandbox.yaml --version v0.3.154
source google-cloud-sdk/path.bash.inc
mvn -B verify -P disable-static-analysis
- run:
Expand Down
2 changes: 0 additions & 2 deletions styx-e2e-test/src/test/java/com/spotify/styx/e2e_tests/AdHocTriggeringIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,12 @@
import java.util.List;
import java.util.Map;

import org.junit.Ignore;
import org.junit.Test;

@AutoService(EndToEndTestBase.class)
public class AdHocTriggeringIT extends EndToEndTestBase {

@Test
@Ignore
public void testAdhocTriggeringFlyteWorkflow() throws Exception {
// Generate workflow configuration
var workflowJson = Json.OBJECT_MAPPER.writeValueAsString(Map.of(
Expand Down
2 changes: 0 additions & 2 deletions styx-e2e-test/src/test/java/com/spotify/styx/e2e_tests/BackfillIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import java.util.Map;
import java.util.stream.Stream;

import org.junit.Ignore;
import org.junit.Test;

@AutoService(EndToEndTestBase.class)
Expand All @@ -57,7 +56,6 @@ public void testBackfill() throws Exception {
}

@Test
@Ignore
public void testBackfillFlyteWorkflow() throws Exception {
// Generate workflow configuration
var workflowJson = Json.OBJECT_MAPPER.writeValueAsString(Map.of(
Expand Down
2 changes: 0 additions & 2 deletions styx-e2e-test/src/test/java/com/spotify/styx/e2e_tests/CreateDeleteWorkflowIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import java.util.List;
import java.util.Optional;

import org.junit.Ignore;
import org.junit.Test;

@AutoService(EndToEndTestBase.class)
Expand All @@ -56,7 +55,6 @@ public void testCreateDeleteWorkflow() throws Exception {
}

@Test
@Ignore
public void testCreateDeleteFlyteWorkflow() throws Exception {
var workflowConfiguration = WorkflowConfiguration.builder()
.id(workflowId1)
Expand Down
6 changes: 4 additions & 2 deletions styx-e2e-test/src/test/java/com/spotify/styx/e2e_tests/EndToEndTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public class EndToEndTestBase {

private static final String FLYTE_DOMAIN = "development";
private static final String FLYTE_LAUNCH_PLAN_NAME = "morning_greeting";
private static final String FLYTE_LAUNCH_PLAN_VERSION = "04e346ca5f43fc2778259d77a2d9f64ce42b2a27";
private static final String FLYTE_LAUNCH_PLAN_VERSION = "v0.3.154";
private static final String RESOURCE_TYPE = "LAUNCH_PLAN";
private static final Map<String, String> REFERENCE_ID =
Map.of(
Expand All @@ -123,7 +123,9 @@ public class EndToEndTestBase {

protected static final Map<String, Object> FLYTE_EXEC_CONF_MAP = Map.of(
"reference_id", REFERENCE_ID,
"input_fields", Map.of()
"input_fields", Map.of(
"day_of_week", 1
)
);

private final CompletableFuture<Service.Instance> styxSchedulerInstance = new CompletableFuture<>();
Expand Down
2 changes: 0 additions & 2 deletions styx-e2e-test/src/test/java/com/spotify/styx/e2e_tests/ScheduledTriggeringIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,12 @@
import java.util.List;
import java.util.Map;

import org.junit.Ignore;
import org.junit.Test;

@AutoService(EndToEndTestBase.class)
public class ScheduledTriggeringIT extends EndToEndTestBase {

@Test
@Ignore
public void testScheduledTriggeringFlyteWorkflow() throws Exception {
// Generate workflow configuration
var workflowJson =
Expand Down
4 changes: 2 additions & 2 deletions styx-e2e-test/src/test/resources/styx-e2e-test-scheduler.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ styx.gke.default.namespace = ${styx.test.namespace}

# flyte conf
styx.flyte.enabled = true
styx.flyte.admin.default.host = "127.0.0.1"
styx.flyte.admin.default.port = 8089
styx.flyte.admin.default.host = "localhost"
styx.flyte.admin.default.port = 30080
styx.flyte.admin.default.insecure = true


Expand Down