Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier, starknet_api): delete blockifier's StarknetVersion #1378

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 13, 2024

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 13, 2024

@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from f6c130b to ed5e796 Compare October 14, 2024 05:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch from 251b684 to 4f6103f Compare October 14, 2024 05:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from ed5e796 to 82c1ffa Compare October 14, 2024 06:54
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch from 4f6103f to a21f175 Compare October 14, 2024 06:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from 82c1ffa to 5f65a5e Compare October 14, 2024 07:10
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch 2 times, most recently from 4b2e9ac to d672c71 Compare October 14, 2024 07:25
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from 5f65a5e to e8e7154 Compare October 14, 2024 09:01
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch from d672c71 to 02c9fc2 Compare October 14, 2024 09:01
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from e8e7154 to 660f811 Compare October 14, 2024 12:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch from 02c9fc2 to 15ec01b Compare October 14, 2024 12:11
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.317 ms 34.348 ms 34.381 ms]
change: [-5.1551% -3.9175% -2.7666%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch 2 times, most recently from b201719 to 19f7359 Compare October 14, 2024 13:18
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.059 ms 34.103 ms 34.153 ms]
change: [-2.0495% -1.8010% -1.5676%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.58%. Comparing base (b0cfe82) to head (932542f).
Report is 425 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/versioned_constants.rs 77.41% 7 Missing ⚠️
crates/starknet_api/src/block.rs 0.00% 3 Missing ⚠️
crates/native_blockifier/src/lib.rs 0.00% 1 Missing ⚠️
crates/papyrus_execution/src/lib.rs 83.33% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (932542f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (932542f)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1378       +/-   ##
===========================================
- Coverage   74.18%   62.58%   -11.61%     
===========================================
  Files         359      181      -178     
  Lines       36240    20332    -15908     
  Branches    36240    20332    -15908     
===========================================
- Hits        26886    12724    -14162     
+ Misses       7220     6679      -541     
+ Partials     2134      929     -1205     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware self-assigned this Oct 14, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from 660f811 to 3e08742 Compare October 15, 2024 10:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch from 19f7359 to 04596b5 Compare October 15, 2024 10:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum branch from 3e08742 to 2a06947 Compare October 15, 2024 10:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch 2 times, most recently from fe71073 to a2c261b Compare October 15, 2024 11:25
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator Author

dorimedini-starkware commented Oct 15, 2024

Merge activity

  • Oct 15, 1:32 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 1:35 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 3:42 PM EDT: A user merged this pull request with Graphite.

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-13-feat_starknet_api_the_starknetversion_type_is_now_an_enum to main October 15, 2024 17:33
@dorimedini-starkware dorimedini-starkware force-pushed the 10-13-refactor_blockifier_starknet_api_delete_blockifier_s_starknetversion branch from a2c261b to 932542f Compare October 15, 2024 17:34
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit b5a8777 into main Oct 15, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants