refactor(execution): delete starknet version string constants and usages

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• refactor(execution): delete starknet version string constants and usages #1382 👈
• refactor(blockifier, starknet_api): delete blockifier's StarknetVersion #1378
• feat(starknet_api): the StarknetVersion type is now an enum #1376
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.43%. Comparing base (b0cfe82) to head (dfb9e29).
Report is 425 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/papyrus_execution/src/lib.rs	40.00%	0 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (dfb9e29). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (dfb9e29)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1382       +/-   ##
===========================================
- Coverage   74.18%   38.43%   -35.76%     
===========================================
  Files         359      108      -251     
  Lines       36240    15688    -20552     
  Branches    36240    15688    -20552     
===========================================
- Hits        26886     6030    -20856     
- Misses       7220     8990     +1770     
+ Partials     2134      668     -1466     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/papyrus_execution/src/lib.rs line 873 at r2 (raw file):

        })
    } else {
        Ok(VersionedConstants::latest_constants())

Is this still relevant? Why not try to get the exact constant and return the latest as a fallback?

Code quote:

    if let Some(starknet_version) = starknet_version {
        Ok(match starknet_version {
            StarknetVersion::V0_13_0 | StarknetVersion::V0_13_1 | StarknetVersion::V0_13_2 => {
                VersionedConstants::get(&starknet_version)?
            }
            _ => VersionedConstants::get(&StarknetVersion::V0_13_3)?,
        })
    } else {
        Ok(VersionedConstants::latest_constants())

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/papyrus_execution/src/lib.rs line 873 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Is this still relevant? Why not try to get the exact constant and return the latest as a fallback?

Yeah I think this function can be deleted, basically; but behavior isn't exactly identical to VersionedConstants::get so I'll leave it to someone from papyrus team.
Note that if you call this with StarknetVersion::V0_9_1 you will get constants matching V0_13_3, and you will get latest_constants (not necessarily V0_13_3) if you send None

[dorimedini-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/papyrus_execution/src/lib.rs line 873 at r2 (raw file):

Previously, dorimedini-starkware wrote…

Yeah I think this function can be deleted, basically; but behavior isn't exactly identical to VersionedConstants::get so I'll leave it to someone from papyrus team.
Note that if you call this with StarknetVersion::V0_9_1 you will get constants matching V0_13_3, and you will get latest_constants (not necessarily V0_13_3) if you send None

deleted the function

---

crates/papyrus_execution/src/lib.rs line 372 at r3 (raw file):

        .get_starknet_version(block_number)?
        .unwrap_or(StarknetVersion::LATEST);
    let versioned_constants = VersionedConstants::get(&starknet_version)?;

@ShahakShama this behavior has changed now:
previously if starknet_version was not one of 0.13.0, 0.13.1 or 0.13.2, you would get 0.13.3 constants; now, you get the constants specified by the version (e.g. 0.13.1.1) or an error (any version below 0.13.0, which is the minimal version for versioned constants).
is that ok?

Code quote:

let versioned_constants = VersionedConstants::get(&starknet_version)?;