Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mempool_infra): server tracing #1492

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Oct 21, 2024

commit-id:1ade9262


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 4.24%. Comparing base (b0cfe82) to head (8f8a0b5).
Report is 461 commits behind head on main.

Files with missing lines Patch % Lines
.../mempool_infra/src/component_server/definitions.rs 50.00% 1 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (8f8a0b5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (8f8a0b5)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1492       +/-   ##
==========================================
- Coverage   74.18%   4.24%   -69.95%     
==========================================
  Files         359     108      -251     
  Lines       36240   13631    -22609     
  Branches    36240   13631    -22609     
==========================================
- Hits        26886     578    -26308     
- Misses       7220   13022     +5802     
+ Partials     2134      31     -2103     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 6ebe7b8 into main Oct 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants