-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean http server module #1499
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
+ Coverage 74.18% 75.79% +1.60%
==========================================
Files 359 361 +2
Lines 36240 38437 +2197
Branches 36240 38437 +2197
==========================================
+ Hits 26886 29133 +2247
+ Misses 7220 7096 -124
- Partials 2134 2208 +74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d79f52b
to
eec02b5
Compare
4cfbcbc
to
8f8a0b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/http_server/src/http_server.rs
line 67 at r1 (raw file):
async fn is_alive() -> HttpServerResult<String> { unimplemented!("Future handling should be implemented here."); }
Why?
Code quote:
#[instrument]
async fn is_alive() -> HttpServerResult<String> {
unimplemented!("Future handling should be implemented here.");
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/http_server/src/http_server.rs
line 67 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Why?
Not going to be implemented in this module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/http_server/src/http_server.rs
line 67 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Not going to be implemented in this module
It will be part of the "monitoring endpoint"
eec02b5
to
63eef3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @Itay-Tsabary-Starkware)
63eef3b
to
0c74411
Compare
commit-id:654340c1
0c74411
to
b6289c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #1502 |
Stack: