Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fee): transaction info creator may fail #506

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 19, 2024

This change is Reviewable

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)


crates/blockifier/src/context.rs line 71 at r1 (raw file):

        TransactionContext {
            block_context: self.clone(),
            tx_info: tx_info_creator.create_tx_info().expect("todo"),

will be handled in an upper branch on the stack

Code quote:

.expect("todo"),

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from 643aa9e to dfa48cb Compare August 19, 2024 11:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 4668bc1 to a9bca83 Compare August 19, 2024 11:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from dfa48cb to 284b275 Compare August 19, 2024 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from a9bca83 to 0edc05f Compare August 19, 2024 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from 284b275 to 5c1091f Compare August 19, 2024 12:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 0edc05f to 162f6e2 Compare August 19, 2024 12:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from 5c1091f to 656eb85 Compare August 19, 2024 13:16
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 162f6e2 to 61d58fd Compare August 19, 2024 13:16
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from 656eb85 to 69c29c6 Compare August 20, 2024 08:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 61d58fd to 3fafce9 Compare August 20, 2024 08:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from 69c29c6 to c8be06a Compare August 20, 2024 08:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 3fafce9 to b6769b7 Compare August 20, 2024 08:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from c8be06a to fa091b8 Compare August 20, 2024 10:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from b6769b7 to dc03a97 Compare August 20, 2024 10:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from 4335170 to c56a171 Compare August 25, 2024 11:58
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from bdd4705 to 0d6e837 Compare August 25, 2024 11:58
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from c56a171 to ab8f232 Compare August 25, 2024 12:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from 0d6e837 to f728fc1 Compare August 25, 2024 12:32
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.58%. Comparing base (c0a128c) to head (2e1ece9).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/blockifier/src/transaction/transactions.rs 86.36% 0 Missing and 3 partials ⚠️
crates/blockifier/src/transaction/errors.rs 0.00% 1 Missing ⚠️
crates/native_blockifier/src/py_validator.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   76.62%   76.58%   -0.04%     
==========================================
  Files         351      351              
  Lines       37102    37100       -2     
  Branches    37102    37100       -2     
==========================================
- Hits        28429    28414      -15     
- Misses       6372     6380       +8     
- Partials     2301     2306       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/hold_validResourceBounds branch from ab8f232 to 00cdc07 Compare August 26, 2024 08:11
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from f728fc1 to 669b111 Compare August 26, 2024 08:11
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Contributor Author

nimrod-starkware commented Aug 28, 2024

Merge activity

@nimrod-starkware nimrod-starkware changed the base branch from nimrod/resources_enum/hold_validResourceBounds to graphite-base/506 August 28, 2024 13:26
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/506 to main August 28, 2024 13:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/tx_info_creator branch from a658b50 to 2e1ece9 Compare August 28, 2024 13:45
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware merged commit f7ff378 into main Aug 28, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants