refactor(fee): rename ResourceBoundsMapping => DeprecatedResourceBoundsMapping

[nimrod-starkware]

This change is 

[nimrod-starkware]

• refactor(fee): tx_args holds valid resource bounds #508 : 2 dependent PRs (#509 , #537 )
• refactor(fee): block context creator may fail #507
• refactor(fee): transaction info creator may fail #506
• build(fee): current tx_info holds validResourceBounds #505
• refactor(fee): rename ResourceBoundsMapping => DeprecatedResourceBoundsMapping #504 👈
• build(fee): define valid resources bounds enum #503
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nimrod-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.46%. Comparing base (e2f2f4a) to head (f607fcc).
Report is 2 commits behind head on main.

Files	Patch %	Lines
...tes/papyrus_protobuf/src/converters/transaction.rs	57.14%	3 Missing and 3 partials ⚠️
crates/starknet_api/src/transaction.rs	0.00%	3 Missing ⚠️
crates/native_blockifier/src/py_declare.rs	0.00%	1 Missing ⚠️
crates/native_blockifier/src/py_deploy_account.rs	0.00%	1 Missing ⚠️
crates/native_blockifier/src/py_invoke_function.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   76.46%   76.46%   -0.01%     
==========================================
  Files         349      349              
  Lines       36872    36874       +2     
  Branches    36872    36874       +2     
==========================================
  Hits        28195    28195              
- Misses       6353     6355       +2     
  Partials     2324     2324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nimrod-starkware]

All this PR is doing is renaming ResourceBoundsMapping => DeprecatedResourceBoundsMapping

Reviewable status: 0 of 33 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @TzahiTaub)

[dorimedini-starkware]

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)

---

crates/papyrus_test_utils/src/lib.rs line 725 at r1 (raw file):

        pub max_price_per_unit: u128,
    }
    pub struct DeprecatedResourceBoundsMapping(pub BTreeMap<Resource, ResourceBounds>);

this type is imported and defined in the same module; why?

Code quote:

pub struct DeprecatedResourceBoundsMapping(pub BTreeMap<Resource, ResourceBounds>);

[nimrod-starkware]

Reviewable status: 32 of 35 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/papyrus_test_utils/src/lib.rs line 725 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this type is imported and defined in the same module; why?

It's under a weird macro that generates some trait implementations, all the types here were declared before

[dorimedini-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[nimrod-starkware]

Merge activity

• Aug 25, 3:32 AM EDT: @nimrod-starkware started a stack merge that includes this pull request via Graphite.
• Aug 25, 3:34 AM EDT: Graphite rebased this pull request as part of a merge.
• Aug 25, 3:44 AM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'merge-gatekeeper', 'run-tests').

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)