Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop user created publications #2780

Closed
wants to merge 6 commits into from

Conversation

billysutomo
Copy link
Contributor

What kind of change does this PR introduce?

fix #2640

What is the current behavior?

Failed to delete user-created publications, causing the migration to create publications to fail.

What is the new behavior?

Add a function to drop user-created publications, excluding supabase_realtime.

@coveralls
Copy link

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11409054896

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 59.741%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/reset/reset.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11400461733: -0.04%
Covered Lines: 6357
Relevant Lines: 10641

💛 - Coveralls

@sweatybridge
Copy link
Contributor

Hey, thanks for the contribution. I've made refactored your query to drop.sql to simplify the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publications are not dropped when resetting remote database
3 participants