Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop user created publications during reset #2789

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 21, 2024

What kind of change does this PR introduce?

Bug fix #2640
supersedes #2780

What is the current behavior?

Failed to delete user-created publications, causing the migration to create publications to fail.

What is the new behavior?

Add a function to drop user-created publications, excluding supabase_realtime.

Co-authored-by: billysutomo <billysutomo.53@gmail.com>
@coveralls
Copy link

coveralls commented Oct 21, 2024

Pull Request Test Coverage Report for Build 11444403439

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.746%

Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
Totals Coverage Status
Change from base Build 11444175365: -0.03%
Covered Lines: 6360
Relevant Lines: 10645

💛 - Coveralls

@sweatybridge sweatybridge merged commit 1a1e908 into develop Oct 21, 2024
9 checks passed
@sweatybridge sweatybridge deleted the drop-pub branch October 21, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publications are not dropped when resetting remote database
2 participants