Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new realtime-js version #408

Merged
merged 23 commits into from
Jun 24, 2024
Merged

Release new realtime-js version #408

merged 23 commits into from
Jun 24, 2024

Conversation

filipecabaco
Copy link
Contributor

What kind of change does this PR introduce?

Release new realtime-js version

filipecabaco and others added 23 commits June 12, 2024 14:27
* feat: Add channel creation endpoint

* Fix the test for createChannel.

* improve tests

* add apikey to url

* add other crud operations

* * add strong random crypto for channel name generation
* abstract http endpoint definition from socket url to single function

* remove random name generation

* change update request to patch; auth made with header

---------

Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
Handle properly jwt tokens and add same logic to broadcast endpoint
* fix: Send proper configuration

* fix: update asserts (#405)

* fix: update asserts

* add extra property to RealtimeChannel

---------

Co-authored-by: Filipe Cabaço <filipecabaco@gmail.com>

* fix: remove unused instance var private

---------

Co-authored-by: Bobbie Soedirgo <31685197+soedirgo@users.noreply.github.com>
Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com>
@filipecabaco filipecabaco merged commit 0a869c6 into master Jun 24, 2024
2 checks passed
@filipecabaco filipecabaco deleted the next branch June 24, 2024 16:43
Copy link

Comment on lines +22 to +28
export type Channel = {
name: string
inserted_at: string
updated_at: string
id: number
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipecabaco It seems like this type isn't being used, but what is it for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check with @w3b6x9 🤔

@@ -66,6 +75,7 @@ export default class RealtimeClient {
apiKey: string | null = null
channels: RealtimeChannel[] = []
endPoint: string = ''
httpEndpoint: string = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this parameter too. Is there another PR that makes use of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be used for http broadcast (aka non ws connection broadcast for edge functions). It will also be useful for longpoll fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants