Release new realtime-js version #408
Merged
+961
−749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add channel creation endpoint * Fix the test for createChannel. * improve tests * add apikey to url * add other crud operations * * add strong random crypto for channel name generation * abstract http endpoint definition from socket url to single function * remove random name generation * change update request to patch; auth made with header --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
Handle properly jwt tokens and add same logic to broadcast endpoint
* fix: Send proper configuration * fix: update asserts (#405) * fix: update asserts * add extra property to RealtimeChannel --------- Co-authored-by: Filipe Cabaço <filipecabaco@gmail.com> * fix: remove unused instance var private --------- Co-authored-by: Bobbie Soedirgo <31685197+soedirgo@users.noreply.github.com> Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com>
chasers
approved these changes
Jun 24, 2024
dshukertjr
reviewed
Jul 8, 2024
Comment on lines
+22
to
+28
| export type Channel = { | ||
| name: string | ||
| inserted_at: string | ||
| updated_at: string | ||
| id: number | ||
| } | ||
|
|
There was a problem hiding this comment.
@filipecabaco It seems like this type isn't being used, but what is it for?
There was a problem hiding this comment.
will check with @w3b6x9 🤔
| @@ -66,6 +75,7 @@ export default class RealtimeClient { | |||
| apiKey: string | null = null | |||
| channels: RealtimeChannel[] = [] | |||
| endPoint: string = '' | |||
| httpEndpoint: string = '' | |||
There was a problem hiding this comment.
Also this parameter too. Is there another PR that makes use of them?
There was a problem hiding this comment.
this should be used for http broadcast (aka non ws connection broadcast for edge functions). It will also be useful for longpoll fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Release new realtime-js version