Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppData file #5104

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Conversation

AsciiWolf
Copy link
Contributor

Add launchable tag that is now required by many AppStream parsers.

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

/cc @Benau

Also consider renaming the AppData file (and the app id) to a rDNS (net.supertuxkart.SuperTuxKart) format. The non-rDNS one is deprecated.

Add launchable tag that is now required by many AppStream parsers
@AsciiWolf
Copy link
Contributor Author

@CodingJellyfish @Alayan-stk-2 Could this please be merged? Thanks!

@CodingJellyfish
Copy link
Member

I'm so sorry, but I'm not very familiar with appdata file atm. So I couldn't make any decision with it.

@AsciiWolf
Copy link
Contributor Author

AsciiWolf commented Jul 2, 2024

Here is an official documentation for AppStream: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#tag-dapp-launchable

"It is required that a launchable tag is present in desktop-application MetaInfo files, unless the MetaInfo data itself contains all required information that a desktop-entry file would have (categories, icon data, ...) and the application can not be launched standalone. This makes the launchable tag a required tag for pretty much all desktop-application components, with only very rare exceptions."

We have to patch this on Flathub: https://github.com/flathub/net.supertuxkart.SuperTuxKart/blob/master/add-app-data-launchable.patch

@AsciiWolf
Copy link
Contributor Author

It basically just tells the AppStream parser what the name of the SuperTuxKart desktop file is - it is useful if the AppStream metadata file id does not match the actual desktop file name, but it does no harm even if the metadata id matches the desktop name, and as I pointed out, it is becoming required by most AppStream parsers nowadays.

@AsciiWolf
Copy link
Contributor Author

@Benau Maybe you could provide some feedback here? :-)

@AsciiWolf
Copy link
Contributor Author

@CodingJellyfish Looks like you are the only active STK team member at the moment. Any chance you could take a look at the official AppStream documentation link (and also the Flathub downstream patch) here and decide whether to merge this PR or not? Thanks!

@CodingJellyfish
Copy link
Member

If any regression is created, feel free to let us know.

@CodingJellyfish CodingJellyfish merged commit e6d0df3 into supertuxkart:master Aug 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants