Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two New skin #5119

Closed
wants to merge 7 commits into from
Closed

Two New skin #5119

wants to merge 7 commits into from

Conversation

willliam9
Copy link

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

@willliam9
Copy link
Author

willliam9 commented Jun 26, 2024

This modification is not intentional, but merely modifies the indentation (for the better?).
WTF - Fix of stk_host.cpp

@CodingJellyfish
Copy link
Member

These new skins are good, but the background of mars doesn't come from official tracks, so further modifications are needed.

@Alayan-stk-2
Copy link
Collaborator

I'm not saying the skins are bad, but I don't think they bring much to the existing set. 5 color variants (+ a dark variant) per base skin is quite enough in my opinion, getting redder red instead of pink-red or getting another shade of green isn't bringing much.

In the future, it would be nice to have the possibility to install skins from the addons, but we have to put some limits on what gets shipped with the game. More choice is not always better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants