updated icons and more shields #262
Conversation
bubble-wrap-style.yaml
Outdated
| filter: function() { return (feature.shield_text.length === 5) } | ||
| sprite: | | ||
| function() { | ||
| var text_len = feature.shield_text.length ? feature.ref.length; |
There was a problem hiding this comment.
This is an incorrect ternary syntax:
feature.shield_text.length ? feature.ref.length;
you need a : with the alternate value, or I think what you actually want to do is maybe this?
feature.shield_text.length || feature.ref.length
There was a problem hiding this comment.
This is causing the current v9 Bubble Wrap (released from this un-merged branch? I can't tell) to fail in various region/zoom combinations.
bubble-wrap-style.yaml
Outdated
| sprite: | | ||
| function() { | ||
| var text_len = feature.shield_text.length ? feature.ref.length; | ||
| return ( 'FR:D-' + feature.text_len + 'char'); |
There was a problem hiding this comment.
Related to above, not sure this is what you actually mean here? Is there a text_len property on the feature itself? I assume you want to use the variable you just defined above, like:
return ( 'FR:D-' + text_len + 'char');
bubble-wrap-style.yaml
Outdated
| international-shields: | ||
| filter: | | ||
| function() { | ||
| return feature.shield_text && |
There was a problem hiding this comment.
You need to make the precedence clearer here, cases where feature.shield_text is null are getting through. Should be:
return feature.shield_text && (
/^AM:AM.*$/.test(feature.network) ||
...
/^ZA:R.*$/.test(feature.network)
)
|
With my most recent commits, I'm not finding any errors right now when trying a broad range of locations (that doesn't mean they aren't there though!). Some of the same fixes need to be applied to Refill (and probably others?). |
bubble-wrap-style.yaml
Outdated
| ((feature.ref && feature.network == 'e-road') && | ||
| /^A .*$/.test(feature.ref) || | ||
| /^N .*$/.test(feature.ref) ) | ||
| return ((feature.ref && !feature.shield_text) && (/^A .*$/.test(feature.ref) || /^N .*$/.test(feature.ref))) || |
There was a problem hiding this comment.
I'm honestly not entirely sure what we're trying to test for here, so the syntax now works (I think the old one was short-circuiting some logic), but it may not be correct...
There was a problem hiding this comment.
This is for A-roads and N-roads in Europe (like in France).
|
Merging this now to reflect what's been released on Nextzen as v9 which is based on beb020b. Since then @bcamper has made a couple bug fixes, so after merging we should release a |
No description provided.