Added support for reindexing of dataExpiration #2211
Conversation
|
Hi @fgalan , If PR seems ok, please merge the PR. |
| } catch (Exception e) { | ||
| LOGGER.warn("Error in collection " + collectionName + " creating index ex=" + e.getMessage()); |
There was a problem hiding this comment.
Should the try/catch be removed (given that createIndex() will deal with the exception internally)?
There was a problem hiding this comment.
It seems the try/catch block is still there... or maybe I'm missing something?
There was a problem hiding this comment.
Ok, will remove try/catch.
| } catch (Exception e) { | ||
| LOGGER.warn("Error in collection " + collectionName + " creating index ex=" + e.getMessage()); | ||
| } // try catch |
There was a problem hiding this comment.
Should the try/catch be removed (given that createIndex() will deal with the exception internally)?
There was a problem hiding this comment.
It seems the try/catch block is still there... or maybe I'm missing something?
There was a problem hiding this comment.
Ok, will remove try/catch.
| * @param options | ||
| * @throws Exception | ||
| */ | ||
| public void createIndex(MongoDatabase db, String collectionName, BasicDBObject keys, |
There was a problem hiding this comment.
Is throws MongoException correct?
Given you capture the exception with the try/catch block, I would say that createIndex() is not able to throw any Exception.
CHANGES_NEXT_RELEASE
Outdated
| [cygnus-common][cygnus-twitter][cygnus-ngsi][cygnus-ngsi-ld] Upgrade log4j from v1 (1.2.17) to v2 (2.17.2) series (#1592) | ||
| [cygnus-ngsi] OracleSQL ngsi sink added (for OracleS 11g and 12c) (#2195) | ||
| [cygnus-ngsi] Removes "_" in schema name for DM -schema family (#2201) | ||
| [cygnus-common] Added support for reindexing of dataExpiration (#2160) |
There was a problem hiding this comment.
| [cygnus-common] Added support for reindexing of dataExpiration (#2160) | |
| [cygnus-common] Added support for reindexing of dataExpiration (#2160, partially) | |
|
Hi @fgalan , Thanks for your support. |
| } catch (Exception e) { | ||
| LOGGER.warn("Error in collection " + collectionName + " creating index ex=" + e.getMessage()); | ||
| } // try catch | ||
| try { | ||
| if (dataExpiration != 0) { | ||
| keys = new BasicDBObject().append("recvTime", 1); | ||
| options = new IndexOptions().name("cyg_raw_exp").expireAfter(dataExpiration, TimeUnit.SECONDS); | ||
| db.getCollection(collectionName).createIndex(keys, options); | ||
| createIndex(db, collectionName, keys, options); |
There was a problem hiding this comment.
Should the try/catch be removed (given that createIndex() will deal with the exception internally)?
There was a problem hiding this comment.
Ok, will remove try/catch.
Fixes issue #2160
Now, we can change dataExpiration value in agent.conf file to get it reflected in database.