Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error output from CalledProcessError #360

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Fix error output from CalledProcessError #360

merged 2 commits into from
Sep 25, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 28, 2023

Fixes:

AttributeError: 'CalledProcessError' object has no attribute 'stdout'�[0m

@evgeni
Copy link
Member

evgeni commented Sep 25, 2023

.stdout/.stderr exist since Python 3.5…, and using .output (which is the same as .stdout) would be losing stderr things (at least on 3.5+)?

@evgeni
Copy link
Member

evgeni commented Sep 25, 2023

OTOH, we use .output everywhere else, so 🤷‍♀️

@evgeni evgeni mentioned this pull request Sep 25, 2023
Merged
@evgeni @ekohl
Update obal/data/modules/copr_build.py
dd453cc 
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@evgeni evgeni merged commit 42f03f3 into theforeman:master Sep 25, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @evgeni @ekohl