Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ros2 mock drivers #2247

Closed
wants to merge 8 commits into from
Closed

add ros2 mock drivers #2247

wants to merge 8 commits into from

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Dec 26, 2023

PR Details

Description

If simulation mode is on, carma-platform will publish automatic driver status messages in ROS2 because ros1_bridge is dropping messages which is timing out the platform depending on the computer's performance.

There should be another PR in carma-carla-integration tool to disable the previous ROS1 node. Supporting PR:
usdot-fhwa-stol/carma-carla-integration#66

Related GitHub Issue

Partially fixes this issue:
#2186
(full fix would be to also port the rosbag mock_drivers, this node doesn't mock rosbags)

Related Jira Key

TODO

Motivation and Context

Integration testing VRU use case - platform is timing out due toe driver status messages being dropped over the ros1_bridge depending on the PCs

How Has This Been Tested?

Simulation PC 1

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN
Copy link
Contributor Author

Closing the PR since the root cause is identified to lie somewhere else

@MishkaMN MishkaMN closed this Dec 27, 2023
@MishkaMN
Copy link
Contributor Author

Closed in favor of #2248

@MishkaMN MishkaMN deleted the feature/ros2_mock_driver branch April 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant