Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/driver status drops #2248

Merged
merged 13 commits into from
Dec 27, 2023
Merged

Fix/driver status drops #2248

merged 13 commits into from
Dec 27, 2023

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Dec 27, 2023

PR Details

Description

The driver status subscriber is listening only 1 depth of msg. Typically there are minimum 4 drivers all publishing to the same topic at 10 Hz, so the subscriber can miss many status updates. This is often leading to driver timeouts although the driver is operational and publishing its status at 10 Hz fine.

Depending on the PC's specs this issue can be more pronounced.

So this PR increases the 1 depth to 20
Also added DEBUG log and cleaned some misleading return calls

Related GitHub Issue

#2186

Related Jira Key

CDAR-643
https://usdot-carma.atlassian.net/browse/CDAR-643

Motivation and Context

Integration testing VRU use case - platform is timing out due toe driver status messages being dropped over the ros1_bridge depending on the PCs

How Has This Been Tested?

Simulation PC 1

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN mentioned this pull request Dec 27, 2023
9 tasks
@MishkaMN MishkaMN self-assigned this Dec 27, 2023
Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MishkaMN MishkaMN merged commit 50f51fb into develop Dec 27, 2023
2 of 3 checks passed
@MishkaMN MishkaMN deleted the fix/driver-status-drops branch December 27, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants