-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/driver status drops #2248
Merged
Merged
Fix/driver status drops #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbourelly999
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
The driver status subscriber is listening only 1 depth of msg. Typically there are minimum 4 drivers all publishing to the same topic at 10 Hz, so the subscriber can miss many status updates. This is often leading to driver timeouts although the driver is operational and publishing its status at 10 Hz fine.
Depending on the PC's specs this issue can be more pronounced.
So this PR increases the 1 depth to 20
Also added DEBUG log and cleaned some misleading return calls
Related GitHub Issue
#2186
Related Jira Key
CDAR-643
https://usdot-carma.atlassian.net/browse/CDAR-643
Motivation and Context
Integration testing VRU use case - platform is timing out due toe driver status messages being dropped over the ros1_bridge depending on the PCs
How Has This Been Tested?
Simulation PC 1
Types of changes
Checklist: