Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[face_detector] Add RGB sample with PR2 #31

Open
wants to merge 1 commit into
base: indigo-devel
Choose a base branch
from

Conversation

130s
Copy link
Contributor

@130s 130s commented Oct 13, 2015

Add a face detection sample launch using RGBD topics with PR2.

  • To run: simply roslaunch face_detector facedetector_rgb_pr2.launch.
  • To see the face detection result, for instance using a nice jsk_rviz_plugins:
    facedetect_pr2_jsk-rviz
  • Originally PR was opened toward pr2_apps but there I was suggested to add this in face_detector

@DLu
Copy link
Member

DLu commented Oct 13, 2015

It doesn't fit in the teleop package, but I'm not sure whether it really fits here either. What do you think @dlaz ?

@dlaz
Copy link
Member

dlaz commented Oct 13, 2015

I agree with @130s's initial PR that this belongs somewhere in the PR2 repos, though I don't see an existing package that looks like a good fit. Another option which could be compelling is to add a people_simulation package which has this launch file, and whatever launch file was used to launch gazebo in the top screenshot. My only concern with that is that I'd rather not add gazebo as a dependency to people.

@DLu, a launch file for running the leg detector in simulation would be awesome too.

@130s
Copy link
Contributor Author

130s commented Oct 16, 2015

Ok, I created people_app package; the launch files I'm willing to add aren't simulation specific, so I think app or sample might be more appropriate. How does this sound?
I'll add tests too.

@DLu DLu added the faces label Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants