Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic rpm build #1234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding basic rpm build #1234

wants to merge 1 commit into from

Conversation

batistein
Copy link

@batistein batistein commented Sep 3, 2022

What's this PR do?
Adds a rpm build target to electron-builder

Any background context you want to provide?
Fixes #1139
You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

@jhpratt
Copy link

jhpratt commented Nov 6, 2023

Off chance someone could take a look at this PR? It's been open for over a year and is very small. I don't know the organizational structure of Zulip, so I don't know who to ping.

update-desktop-database /usr/share/applications || true

# Clean up configuration for old Bintray repository
rm -f /etc/apt/zulip.list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will never exist in an RPM system.

@timabbott
Copy link
Member

It will be considered when we're next doing an Electron release. Though given the above bug, this seems to be somewhat sloppily implemented, so no promised that it'll prove easy to integrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a .rpm file for Fedora
4 participants