Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic rpm build #1234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ npm run pack
npm run dist
```

It will start the packaging process. The ready for distribution file (e.g. dmg, windows installer, deb package) will be outputted to the `dist` directory.
It will start the packaging process. The ready for distribution file (e.g. dmg, windows installer, deb package, rpm package) will be outputted to the `dist` directory.
2 changes: 1 addition & 1 deletion docs/desktop-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

## - All the installer i.e.

- Linux (.deb, AppImage)
- Linux (.deb, .rpm, AppImage)
- Mac - (.dmg)
- Windows - (web installer for 32/64bit)

Expand Down
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"description": "Zulip Desktop Client for Linux",
"target": [
"deb",
"rpm",
"tar.xz",
"AppImage",
"snap"
Expand All @@ -98,6 +99,11 @@
"./packaging/deb-release-upgrades.cfg=/etc/update-manager/release-upgrades.d/zulip-desktop.cfg"
]
},
"rpm": {
"packageCategory": "net",
"synopsis": "Zulip Desktop App",
"afterInstall": "./packaging/rpm-after-install.sh"
},
"snap": {
"synopsis": "Zulip Desktop App"
},
Expand Down
13 changes: 13 additions & 0 deletions packaging/rpm-after-install.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/bin/bash

# Link to the binary
ln -sf '/opt/${productFilename}/${executable}' '/usr/bin/${executable}'

# SUID chrome-sandbox for Electron 5+
chmod 4755 '/opt/${productFilename}/chrome-sandbox' || true

update-mime-database /usr/share/mime || true
update-desktop-database /usr/share/applications || true

# Clean up configuration for old Bintray repository
rm -f /etc/apt/zulip.list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will never exist in an RPM system.