fix ament_clang_format test dependency for CMake #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardvdK
force-pushed
the
patch-1
branch
2 times, most recently
from
3dc4381
to
9f1fa7d
Compare
I tried the <test_depend>ament_cmake_clang_format</test_depend> but colcon test didn't find any tests in this way. After changing it to ament_cmake_clang_format it worked. From the ament_clang_format doc: "How to run the check from within a CMake ament package as part of the tests? -> The CMake integration is provided by the package ament_cmake_clang_format" Signed-off-by: Richard van de Ketterij <richard.van.de.ketterij@nobleo.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the <test_depend>ament_clang_format</test_depend> but colcon test didn't find any tests in this way. After changing it to ament_cmake_clang_format it worked.
From the ament_clang_format doc: "How to run the check from within a CMake ament package as part of the tests? -> The CMake integration is provided by the package ament_cmake_clang_format"
Signed-off-by: RichardvdK Richard.van.de.ketterij@nobleo.nl